Opened 2 years ago
Closed 7 weeks ago
#25091 closed enhancement (wontfix)
Make 'out/update' deterministic across instances
| Reported by: | iwakeh | Owned by: | metrics-team |
|---|---|---|---|
| Priority: | Medium | Milestone: | |
| Component: | Metrics/Onionoo | Version: | |
| Severity: | Normal | Keywords: | |
| Cc: | Actual Points: | 0.1 | |
| Parent ID: | #25002 | Points: | |
| Reviewer: | Sponsor: |
Description
Derived from comments 9 to 11 in #25002.
Summary:
Instead of current system time use the latest time of the two valid after timestamps (relays and bridges).
Child Tickets
Change History (1)
comment:1 Changed 7 weeks ago by
| Actual Points: | → 0.1 |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Or let's not do it. I already had a working patch, but then realized that the timestamp in
out/updateis used for different two purposes: 1) forserver.NodeIndexerto quickly check whether there's new data to index and 2) for the variouswriter.*DocumentWriterto obtain a list of status files that were written or updated after the last execution. We cannot simply use the maximum last-seen time as timestamp in theout/updatefile, or we'd rewrite lots of document files from status files that haven't changed. We could have two separate filesstatus/updateandout/updatefor the two different purposes. But is that really worth the effort, just to makeout/updatedeterministic across instances? I don't think so. Closing as wontfix.