Opened 3 years ago

Closed 2 years ago

#25095 closed task (fixed)

Update dir-spec.txt with recent consensus param additions

Reported by: arma Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, tor-dos
Cc: Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:


We have a section in dir-spec.txt that tries to describe the possible consensus parameters, and their ranges, and their meanings.

We just added a bunch of new ones in #24902. And maybe we missed a few recently, like hs_service_max_rdv_failures.

We should patch dir-spec.txt to specify all of them.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by dgoulet

Cc: dgoulet removed
Keywords: tor-spec tor-dos added; torspec removed
Owner: set to dgoulet
Status: newaccepted
Type: defecttask

comment:2 Changed 2 years ago by dgoulet

Status: acceptedneeds_review

Spec branch: ticket25095_01

comment:3 Changed 2 years ago by ahf

Reviewer: ahf
Status: needs_reviewneeds_revision

I think the patch looks good, I have two questions:

  1. DoSCircuitCreationBurst and DoSCircuitCreationRate seems related. Is DoSCircuitCreationRate also per Client IP address or not? Maybe that is worth addressing explicitly if it is.
  1. DoSCircuitCreationDefenseType is a bit vaguely defined here -- what are the possible values this could have? From the other entries I think it's possible to deduct the data-type, but not for this one.

Other than that it looks good.

comment:4 Changed 2 years ago by dgoulet

Status: needs_revisionneeds_review

Thanks for the review!

Fixup commit 032af0b700c4b915 pushed. I've also put the possible values for the DoSConnectionDefenseType.

comment:5 Changed 2 years ago by ahf

Status: needs_reviewmerge_ready


comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged to torspec!

Note: See TracTickets for help on using tickets.