#25097 closed defect (implemented)

Remove commented functions in crypto module

Reported by: ffmancera Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: easy, intro
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I noticed there are some code commented in crypto module.

  • struct CRYPTO_dynlock_value
  • openssl_dynlock_create_cb_
  • openssl_dynlock_lock_cb_
  • openssl_dynlock_destroy_cb_

OpenSSL never uses these callbacks anymore so the code is disabled. Should we remove this code?

Child Tickets

Change History (3)

comment:1 Changed 18 months ago by nickm

Yes, we should IMO.

comment:2 Changed 18 months ago by ffmancera

Status: newneeds_review

Done, check my github branch bug25097.

comment:3 Changed 18 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

merged to master; thanks!

Note: See TracTickets for help on using tickets.