Opened 15 months ago

Last modified 3 months ago

#25099 new task

Update nightly version number

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, tbb-update
Cc: boklm, mcs, brade, ln5 Actual Points:
Parent ID: #18867 Points:
Reviewer: Sponsor:

Description

In order to be able to update Tor Browser nightly builds each day, we need each build to have a different version number.

Currently the version for nightly builds is set to tbb-nightly. I think we could change it to the current day with something like 2018.01.31.

Child Tickets

Change History (6)

comment:1 Changed 15 months ago by mcs

For the updater to work correctly, the version number needs to conform to Mozilla's standard format (and newer releases need to have a higher number). See: https://developer.mozilla.org/en-US/docs/Mozilla/Toolkit_version_format

I am not sure what Mozilla uses for nightly Firefox builds, but maybe we can do something similar.

comment:2 in reply to:  1 ; Changed 15 months ago by mcs

Replying to mcs:

I am not sure what Mozilla uses for nightly Firefox builds, but maybe we can do something similar.

Apparently they use an alpha version number, e.g., appVersion="60.0a1" and rely on the fact that they change the buildID for each nightly build, e.g., buildID="20180131100706".

comment:3 in reply to:  2 ; Changed 15 months ago by boklm

Replying to mcs:

For the updater to work correctly, the version number needs to conform to Mozilla's standard format (and newer releases need to have a higher number). See: https://developer.mozilla.org/en-US/docs/Mozilla/Toolkit_version_format

Thanks for the link. If I understand it correctly, it seems a version number like 2018.01.31 would conform to this standard format. We could also include the alpha version number in addition to the date, like 8.0a1.2018.01.31.

Replying to mcs:

Replying to mcs:

I am not sure what Mozilla uses for nightly Firefox builds, but maybe we can do something similar.

Apparently they use an alpha version number, e.g., appVersion="60.0a1" and rely on the fact that they change the buildID for each nightly build, e.g., buildID="20180131100706".

I think it would be possible for us to do it like this, but would require some changes in our tools:

  • change the mar file names to include the buildID number
  • change the script we use to generate incremental mars to be able to do it from two builds that have the same version number but a different buildID
  • change the script we use to generate XML update responses to handle URLs with a buildID

I think updating the version number only would require less changes. So I'm wondering if there is some other reason that would still make us prefer doing it with the buildID like Mozilla.

comment:4 in reply to:  3 Changed 15 months ago by mcs

Replying to boklm:

Replying to mcs:

For the updater to work correctly, the version number needs to conform to Mozilla's standard format (and newer releases need to have a higher number). See: https://developer.mozilla.org/en-US/docs/Mozilla/Toolkit_version_format

Thanks for the link. If I understand it correctly, it seems a version number like 2018.01.31 would conform to this standard format. We could also include the alpha version number in addition to the date, like 8.0a1.2018.01.31.

I think that would work.

Replying to mcs:

Replying to mcs:

I am not sure what Mozilla uses for nightly Firefox builds, but maybe we can do something similar.

Apparently they use an alpha version number, e.g., appVersion="60.0a1" and rely on the fact that they change the buildID for each nightly build, e.g., buildID="20180131100706".

I think it would be possible for us to do it like this, but would require some changes in our tools:

  • change the mar file names to include the buildID number
  • change the script we use to generate incremental mars to be able to do it from two builds that have the same version number but a different buildID
  • change the script we use to generate XML update responses to handle URLs with a buildID

I think updating the version number only would require less changes. So I'm wondering if there is some other reason that would still make us prefer doing it with the buildID like Mozilla.

I don't know of any reason to favor one approach over another, except doing it like Mozilla does might make it less likely that things will break for us in the future. But that is only a theoretical concern, and if our nightly updates break it would not be the end of the world.

comment:5 Changed 3 months ago by gk

Keywords: tbb-updater added

comment:6 Changed 3 months ago by gk

Keywords: tbb-update added; tbb-updater removed

Renaming keyword to make it a bit broader

Note: See TracTickets for help on using tickets.