Opened 2 years ago

Closed 2 years ago

#25105 closed defect (fixed)

Look at PRT_HSREND, not PRT_HSDIR, for supports_v3_rendezvous_point

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: dgoulet, asn Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:


This code seems wrong:

+    rs->supports_v3_rendezvous_point =
+      protocol_list_supports_protocol(tok->args[0], PRT_HSDIR,
+                                      PROTOVER_HS_RENDEZVOUS_POINT_V3);

It should say "PRT_HSREND", not "PRT_HSDIR".

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by nickm

Found while working on #25008.

(edited to fix number)

Last edited 2 years ago by nickm (previous) (diff)

comment:2 Changed 2 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:3 Changed 2 years ago by nickm

Cc: dgoulet asn added
Status: acceptedneeds_review

I have a fix for 0.3.3 as part of my #25008 branch. There is a fix for 0.3.2.x in my bug25105_032 branch.

cc'ing asn and dgoulet here in case the impact of this ticket is something unexpected.

comment:4 Changed 2 years ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready


comment:5 Changed 2 years ago by nickm

merged the 0.3.2 one to 0.3.2, and the master one to master.

comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.