Opened 19 months ago

Closed 6 months ago

Last modified 5 months ago

#25110 closed defect (fixed)

Warn operators who set MyFamily that they must also set ContactInfo

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy, intro, 034-triage-20180328, 034-removed-20180328, 031-unreached-backport-maybe, 032-unreached-backport-maybe
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: nickm Sponsor:

Description (last modified by teor)

We added this advice to the man page in 0.3.2.9 0.3.2.10, but a config warning could help, too.

The logic is:

If an operator sets MyFamily, and does not set ContactInfo:

  • warn the operator that they should set ContactInfo

Child Tickets

Change History (18)

comment:1 Changed 19 months ago by teor

Description: modified (diff)

comment:2 Changed 18 months ago by cypherpunks

how about exiting with an error instead of just warning?

comment:3 Changed 18 months ago by teor

Keywords: 025-backport-maybe 031-backport-maybe 029-backport-maybe added

Exiting would be a good idea, if relays will be kicked out of the consensus when they have MyFamily but no ContactInfo.
Otherwise, it seems disproportionate.

comment:4 Changed 17 months ago by nickm

Keywords: 034-triage-20180328 added

comment:5 Changed 17 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:6 Changed 17 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:7 Changed 14 months ago by teor

Keywords: 031-unreached-backport added

0.3.1 is end of life, there are no more backports.
Tagging with 031-unreached-backport instead.

comment:8 Changed 14 months ago by teor

Keywords: 031-unreached-backport-maybe added; 031-backport-maybe removed

0.3.1 is end of life, there are no more 0.3.1 maybe backports.
Tagging with 031-unreached-backport-maybe.

comment:9 Changed 14 months ago by teor

Keywords: 031-unreached-backport removed

Keywords does substrings in search, but not replace.

comment:10 Changed 9 months ago by teor

Keywords: 032-unreached-backport added

0.3.2 is end of life, so 032-backport is now 032-unreached-backport.

comment:11 Changed 9 months ago by teor

Keywords: 032-unreached-backport-maybe added; 032-backport-maybe removed

Tag 032-backport-maybe with 032-unreached-backport-maybe

comment:12 Changed 9 months ago by teor

Keywords: 032-unreached-backport removed

Remove redundant 032-unreached-backport on 032-unreached-backport-maybe

comment:14 Changed 6 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.1.x-final
Status: newneeds_review

comment:15 Changed 6 months ago by dgoulet

Reviewer: nickm

comment:16 Changed 6 months ago by nickm

Status: needs_reviewmerge_ready

looks good to me! Let's take it in 0.4.1 only.

comment:17 Changed 6 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged in master. Thanks!

comment:18 Changed 5 months ago by teor

Keywords: 025-backport-maybe 029-backport-maybe 033-backport-maybe removed

No backport.

Note: See TracTickets for help on using tickets.