Opened 8 months ago

Closed 8 months ago

#25111 closed defect (fixed)

Don't compile Yasm on our own anymore for Windows Tor Browser

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201801R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

With the switch to Debian we can now rely on Yasm as shipped by the distribution. It is sufficiently recent enough to not break Firefox compilation.

Child Tickets

Change History (3)

comment:1 Changed 8 months ago by boklm

Keywords: TorBrowserTeam201801R added
Status: newneeds_review

There is a patch for review in branch bug_25111 from my repo:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_25111&id=57f544ca8590b00b609b62132aeb2ae7abfa7779

I successfully ran make testbuild-windows-i686 testbuild-windows-x86_64 with this patch.

comment:2 Changed 8 months ago by gk

Looks good, thanks. Merged to master (commit 57f544ca8590b00b609b62132aeb2ae7abfa7779).

comment:3 Changed 8 months ago by gk

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.