Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#25112 closed defect (fixed)

Tor Browser 7.5 is not working on Windows Vista 64bit

Reported by: gk Owned by: pospeselr
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: ff60-esr-will-have, TorBrowserTeam201803R
Cc: jllover, arthuredelstein, mcs, tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We have some users on the blog complaining about Tor Browser 7.5 being broken on Windows Vista 64bit. See, for instance:https://blog.torproject.org/comment/273815#comment-273815

The error ("TypeError: frameLoader.tabParent is null") might indicate that our enabled sandboxing is breaking things for them.

Child Tickets

Attachments (1)

0001-Bug-25112-Tor-Browser-7.5-is-not-working-on-Windows-.patch (3.8 KB) - added by pospeselr 9 months ago.
disables sandbox on Vista and below when in wow64 scenario

Download all attachments as: .zip

Change History (25)

comment:1 Changed 10 months ago by gk

FWIW: Windows Vista is EOL for almost a year now. Might still be worth trying to understand what the issue is and fixing it if it is easy.

comment:2 Changed 10 months ago by arma

#25130 also got closed as a duplicate.

comment:3 Changed 10 months ago by gk

Cc: jllover added
Priority: MediumHigh
Severity: NormalMajor

#25130 is a duplicate.

jllover: I assume this issue shows up due to us enabling sandboxing support for Windows with 7.5. Alas, this did not get caught in our testing and seems to be only affecting Windows Vista which is not supported anymore from Microsoft.

Not sure if you still can open new tabs but if so, open one and enter about:config in the URL bar and then you can test whether disabling the sandbox solves the issue for you by setting security.sandbox.content.level to 0.

comment:4 Changed 10 months ago by arthuredelstein

Cc: arthuredelstein added

comment:5 Changed 10 months ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:6 Changed 10 months ago by mcs

Cc: mcs added

comment:7 Changed 10 months ago by pospeselr

Was able to reproduce on a Vista 64-bit SP2 VM this afternoon and also confirmed the issue does not occur on 32-bit. Setting sandbox content level to 0 'fixes' the issue.

comment:8 Changed 10 months ago by gk

Keywords: TorBrowserTeam201802 added

comment:9 Changed 9 months ago by cypherpunks

Status: assignedneeds_information

Vista is vulnerable without security patches. Why are you wasting your resources on it?

comment:10 in reply to:  9 Changed 9 months ago by cypherpunks

Status: needs_informationassigned

Replying to cypherpunks:

Vista is vulnerable without security patches. Why are you wasting your resources on it?

But the current ESR of Firefox still supports Vista and XP, which means that TB should support them as well as ditch them when Firefox ditches them (i.e. this next ESR).

comment:11 Changed 9 months ago by pospeselr

This failure happens due to a missing wow_helper.exe in the TBB package. Everything works just fine when I copy over the version packaged with latest Firefox. Currently investigating why this exe isn't being built or packaged.

An interesting sidenote, the latest Chromium sandbox code no longer uses wow_helper.exe. Seems like it was removed in Chromium commit 1812d0d777dbe2162e88f6a0a205c8b483008626 as part of removing support for XP and Vista.

comment:12 in reply to:  11 Changed 9 months ago by cypherpunks

Status: assignedneeds_information

Replying to pospeselr:

This failure happens due to a missing wow_helper.exe in the TBB package.

They didn't tell you?

Everything works just fine when I copy over the version packaged with latest Firefox.

What do you mean? It was removed as part of removing support for Vista.

Currently investigating why this exe isn't being built or packaged.

The same way why helper.exe isn't being built, and then they wonder why staged updates don't work.

An interesting sidenote, the latest Chromium sandbox code no longer uses wow_helper.exe. Seems like it was removed in Chromium commit 1812d0d777dbe2162e88f6a0a205c8b483008626 as part of removing support for XP and Vista.

It was needed for Vista only.

comment:13 Changed 9 months ago by gk

So, FWIW, we are hitting essentially https://bugzilla.mozilla.org/show_bug.cgi?id=1110760.

comment:14 Changed 9 months ago by gk

Status: needs_informationassigned

comment:15 Changed 9 months ago by boklm

Cc: tbb-team added

comment:16 Changed 9 months ago by pospeselr

Keywords: TorBrowserTeam201802R added; TorBrowserTeam201802 removed

comment:17 Changed 9 months ago by pospeselr

Keywords: TorBrowserTeam201803R added; TorBrowserTeam201802R removed
Status: assignedneeds_review

comment:18 Changed 9 months ago by mcs

I don't have a way to test this patch, but it looks okay. I have a few comments:

  • To match Mozilla's style inside GeckoChildProcessHost.cpp you should add a space after the if keywords.
  • It is okay to check for the existence of IsWow64Process() but I think it will be present in all versions of Windows we care about since I am pretty sure we required WinXP sp2 or later. That said, I am not sure what happens if you try try to run on something older so maybe we should keep the GetProcAddress fun.
  • I don't think having TweakSandboxLevel() adds much; I would just put code like this inside GeckoChildProcessHost::PrepareLaunch():
      if (ShouldLowerSandboxLevel(mSandboxLevel)) {
        mSandboxLevel = 0;
      }
    
Last edited 9 months ago by mcs (previous) (diff)

comment:19 Changed 9 months ago by gk

Keywords: TorBrowserTeam201803 added; TorBrowserTeam201803R removed
Status: needs_reviewneeds_revision

I tested on a Windows 7 and Windows 8 box both 64bit and 32bit Tor Browser builds and they behaved as they should. Marking this as needs_revision for the things mcs and brade found.

Changed 9 months ago by pospeselr

disables sandbox on Vista and below when in wow64 scenario

comment:20 Changed 9 months ago by pospeselr

Ignore that 25147 patch, I'm bad with computers

comment:21 Changed 9 months ago by pospeselr

Keywords: TorBrowserTeam201803R added; TorBrowserTeam201803 removed
Status: needs_revisionneeds_review

comment:22 Changed 9 months ago by gk

Looks good to me and testing the resulting binaries on Windows 8 still works as expected.

comment:23 Changed 9 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

I picked that up for 7.5.1 (commit 9b556c256502511f9a89d7835f6e54cc3ee7c711 on tor-browser-52.6.0esr-7.5-2) and 8.0a3 (commit 0b48ad93d9b7062afcdb65cfb9634854209ab5de on tor-browser-52.6.0esr-8.0-2).

mcs/brade: Let me know if we should back out the updated patch for some reason.

comment:24 in reply to:  23 Changed 9 months ago by mcs

Replying to gk:

mcs/brade: Let me know if we should back out the updated patch for some reason.

Looks good to me.

Note: See TracTickets for help on using tickets.