Changes between Initial Version and Version 1 of Ticket #25112, comment 18


Ignore:
Timestamp:
Mar 5, 2018, 9:05:26 PM (22 months ago)
Author:
mcs
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25112, comment 18

    initial v1  
    1 I don't have a way to test this patch, but it looks okay. I have a couple of comments:
     1I don't have a way to test this patch, but it looks okay. I have a few comments:
    22- To match Mozilla's style inside `GeckoChildProcessHost.cpp` you should add a space after the `if` keywords.
    33- It is okay to check for the existence of `IsWow64Process()` but I think it will be present in all versions of Windows we care about since I am pretty sure we required WinXP sp2 or later. That said, I am not sure what happens if you try try to run on something older so maybe we should keep the `GetProcAddress` fun.