Opened 2 years ago

Closed 15 months ago

#25116 closed defect (fixed)

hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: tor-hs, sos, easy, 029-backport, 031-unreached-backport, 032-unreached-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Assume an email server where clients often keep a connection open and regularly exchange traffic on them.

Making that email server an .onion, RP circuits will stay open for a while and more than 1800 seconds which is the cutoff of circuit_log_ancient_one_hop_circuits() to log single hop circuits.

I think we want to ignore to log anything service related in there. Some v3 services have started seeing that heartbeat more and more in the last days.

Related: #8387

Child Tickets

Change History (13)

comment:1 Changed 2 years ago by dgoulet

Owner: set to dgoulet
Status: newaccepted

comment:2 Changed 2 years ago by dgoulet

Status: acceptedneeds_review

Branch: bug25116_033_01

comment:3 Changed 2 years ago by nickm

LGTM. Is this a bug against some earlier branch, though?

comment:4 Changed 2 years ago by dgoulet

Yes goes back to 029 but I wasn't sure this would qualify for a backport. If yes, I'm happy to provide an 029 branch.

comment:5 Changed 2 years ago by nickm

Let's have the branch against 0.2.9, so that we can backport it in case anybody complains about getting these errors in earlier versions. It's a simple enough fix.

comment:6 Changed 2 years ago by dgoulet

Sure, 029 branch: bug25116_029_01

Commit 7ce8d5513ba38825. Hope that is ok!

comment:7 Changed 2 years ago by nickm

Keywords: 031-backport 029-backport 032-backport added
Milestone: Tor: 0.3.3.x-finalTor: 0.3.2.x-final
Status: needs_reviewmerge_ready

great! merging to 0.3.3, marking for possible backport.

comment:8 Changed 2 years ago by teor

Keywords: 031-unreached-backport added; 031-backport removed

0.3.1 is end of life, there are no more backports.
Tagging with 031-unreached-backport instead.

comment:9 Changed 19 months ago by teor

Keywords: 032-unreached-backport added; 032-backport removed

0.3.2 is end of life, so 032-backport is now 032-unreached-backport.

comment:10 Changed 19 months ago by teor

Milestone: Tor: 0.3.2.x-finalTor: 0.2.9.x-final

These tickets can't be backported to 0.3.2, because it is end of life.
But they can still be backported to 0.2.9.

comment:11 Changed 15 months ago by teor

Version: Tor: unspecified

This is a one-line logging fix on an LTS release. It's low risk, and worth backporting.

Since it's an old branch, I opened a pull request to make sure that the tests still pass:

comment:12 Changed 15 months ago by teor

Version: Tor: unspecifiedTor:

comment:13 Changed 15 months ago by teor

Resolution: fixed
Status: merge_readyclosed

I merged #25116, #25113, and #24903 into 0.2.9.

CI passed on:

  • the original branches,
  • each branch merged into the current maint-0.2.9, and
  • all 3 branches merged together into maint-0.2.9, then merged into release-0.2.9.
Note: See TracTickets for help on using tickets.