Opened 21 months ago

Last modified 21 months ago

#25134 new defect

Import strings from all locales in torbutton import-translations.sh

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201802
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I have been looking at how to add more locales to Tor Browser and I noticed that tor-launcher.git and torbutton.git handle translations differently. In tor-launcher, the script import-translations.sh imports new strings from all locales provided by Transifex, not just the ones deploy in Tor Browser. But in torbutton, import-translations.sh we are only importing strings from a specific list of locales and ignoring the rest. I would suggest we should change torbutton to import all locales, because then:

  • We won't have to keep a list of locales in torbutton sync'd with Tor Browser.
  • It will potentially facilitate building a multi-local Tor Browser.

Child Tickets

Change History (5)

comment:1 Changed 21 months ago by arthuredelstein

Keywords: TorBrowserTeam201702R added
Status: newneeds_review

comment:2 Changed 21 months ago by gk

Keywords: TorBrowserTeam201802R added; TorBrowserTeam201702R removed

comment:3 Changed 21 months ago by gk

Status: needs_reviewneeds_information

I am not exactly sure about the rationale for the difference between Tor Launcher and Torbutton (maybe mcs/brade know that), but I could imagine one reason would be that Tor Launcher is not only a Tor Browser thing while Torbutton is.

Arthur: Could you elaborate on the benefit of shipping all locales to all users right now even though at the moment there are no multi-locale Tor Browser versions available? I understand why we would want that in case those were about to ship but it does not seem to be the case that this is happening (any time soon).

The big downside is a larger bundle for everyone, longer download times, etc. without any current benefit.

comment:4 in reply to:  3 Changed 21 months ago by arthuredelstein

Keywords: TorBrowserTeam201802 added; TorBrowserTeam201802R removed
Status: needs_informationnew

Replying to gk:

I am not exactly sure about the rationale for the difference between Tor Launcher and Torbutton (maybe mcs/brade know that), but I could imagine one reason would be that Tor Launcher is not only a Tor Browser thing while Torbutton is.

Arthur: Could you elaborate on the benefit of shipping all locales to all users right now even though at the moment there are no multi-locale Tor Browser versions available? I understand why we would want that in case those were about to ship but it does not seem to be the case that this is happening (any time soon).

I'm OK with waiting on this patch until we do. Setting as 'new' for now.

The big downside is a larger bundle for everyone, longer download times, etc. without any current benefit.

It's about a 200 kb increase zipped, so I thought that probably didn't matter much as a small fraction of the whole download size and slightly cut down on code complexity. But I agree it doesn't seem necessary yet.

comment:5 in reply to:  3 Changed 21 months ago by mcs

Replying to gk:

I am not exactly sure about the rationale for the difference between Tor Launcher and Torbutton (maybe mcs/brade know that), but I could imagine one reason would be that Tor Launcher is not only a Tor Browser thing while Torbutton is.

That is basically the answer. Tails contributed a patch that modified how Tor Launcher pulls in the localized strings:
https://gitweb.torproject.org/tor-launcher.git/commit/?id=951b654f29868d8b52c1c8a0713346678a64fde6

Note: See TracTickets for help on using tickets.