#25148 closed defect (fixed)

Make geoip_client_cache_total_allocation() use geoip_client_history_cache_size

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-geoip, performance
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In commit 4d812e29b9b1ec88, we forgot to make the function returning the total allocation return the counter instead of going over all entries which hugs the CPU like crazy.

Child Tickets

Change History (4)

comment:1 Changed 17 months ago by dgoulet

Status: assignedmerge_ready

See branch: bug25148_033_01

Fix is trivial.

comment:2 Changed 17 months ago by nickm

lgtm; please let me know once this is cherry-picked onto ticket24902_029_01?

comment:3 in reply to:  2 Changed 17 months ago by dgoulet

Replying to nickm:

lgtm; please let me know once this is cherry-picked onto ticket24902_029_01?

Cherry-picked in ticket24902_029_05. (notice the _05). Commit f08fa974600625e4

comment:4 Changed 17 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.