Opened 16 months ago

Last modified 14 months ago

#25149 new enhancement

Hook rephist subsystem into the OOM handler

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: performance, tor-relay, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It appears we do not look at the rephist subsystem in the OOM handler.

But, we do track memory allocation with rephist_total_alloc counter. That counter needs to be audited because I found two places where we allocate memory for stats but do not increment that global counter.

Bug #25141 could have been avoided in some ways with this or at least made obvious to the operator without tor crashing.

Child Tickets

Change History (3)

comment:1 Changed 14 months ago by nickm

Keywords: 034-triage-20180328 added

comment:2 Changed 14 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:3 Changed 14 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.