Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#2515 closed defect (fixed)

Fix timeout syntax and sys.exit bug in torperf

Reported by: karsten Owned by: karsten
Priority: Low Milestone:
Component: Metrics/CollecTor Version:
Severity: Keywords: TorPerfIteration20110305
Cc: Sebastian Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor:

Description

The timeout script shipped with Debian Squeeze uses a different syntax than the one shipped with Lenny. We should update the HOWTO. We might also ponder shipping our own timeout script.

Also, there's a bug in line 15 of extra_stats.py, probably a missing colon:

File "../extra_stats.py", line 15
    if not self._conn
                    ^
SyntaxError: invalid syntax

Child Tickets

Change History (8)

comment:1 Changed 9 years ago by Sebastian

Added the missing colon

comment:2 Changed 9 years ago by ioerror

I put the patches and the relevant fixes into bug #2476 - if you merge those, the torperf stuff works reasonably well on modern Ubuntu and I suspect also on Debian Squeeze.

comment:3 Changed 9 years ago by karsten

Parent ID: #2607

comment:4 Changed 8 years ago by karsten

Keywords: TorPerfIteration20110305 added
Parent ID: #2607

comment:5 Changed 8 years ago by karsten

Status: newneeds_review

Please review branch task2515 in my public repository.

comment:6 Changed 8 years ago by Sebastian

Looks good to me.

comment:7 Changed 8 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Thanks for reviewing! Merged and closing.

comment:8 Changed 8 years ago by dchasteen

Points: 2

Added points from sprint planning meeting.

Note: See TracTickets for help on using tickets.