#25158 closed defect (fixed)

Don't assume everyone uses your symlink structure.

Reported by: tom Owned by: tom
Priority: Medium Milestone:
Component: Metrics/Consensus Health Version:
Severity: Normal Keywords:
Cc: Sebastian, metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

os.chdir(os.path.join(os.path.dirname(__file__), 'stem'))
		stem_version = subprocess.check_output(['git', 'rev-parse', '--short', 'HEAD'])
		os.chdir('../../')

You should navigate down to stem and then navigate out of it using os.path.dirname(file).

Also you should double check that the stem version is different from depictor, to make sure you captured it correctly.

Child Tickets

Change History (3)

comment:1 Changed 21 months ago by tom

Cc: Sebastian added
Status: newneeds_information

Sebastian, could you tell me if this patch works for your deployment?

https://gitweb.torproject.org/user/tom/depictor.git/commit/?id=8574f72aa86ef940c53faff0e744306e5fde06b8

comment:2 Changed 19 months ago by irl

Cc: metrics-team added

Adding metrics-team to cc

comment:3 Changed 12 months ago by tom

Resolution: fixed
Status: needs_informationclosed

No info, landed the change already, going to resolve this.

Note: See TracTickets for help on using tickets.