Opened 4 months ago

Closed 3 months ago

#25170 closed enhancement (implemented)

explicitly mention email address to contact for rejected relays

Reported by: cypherpunks Owned by: dgoulet
Priority: Low Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: 032-backport-maybe
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

from the discussion on bad-relays@..

When we reject relays the operator gets to see something like this in their logs:

[warn] http status 400 ("Fingerprint is marked rejected -- please contact us?") response from dirserver 'IP:Port'. Please correct.

Lets change this to:

"Fingerprint is marked rejected, if you think this is a mistake please set a ContactInfo and send an email to bad-relays@… mentioning your fingerprint(s)"

Child Tickets

Change History (8)

comment:1 Changed 4 months ago by nickm

Milestone: Tor: 0.3.4.x-final

I'd take a patch for this in 0.3.3 if somebody writes it soon. I'd suggest that the test say "set a valid email address in ContactInfo" rather than just "set a ContactInfo"

comment:2 Changed 3 months ago by dgoulet

Milestone: Tor: 0.3.4.x-finalTor: 0.3.3.x-final
Owner: set to dgoulet
Status: newaccepted

See branch: ticket25170_033_01

I did the new message for both when a fingerprint or an address is marked as rejected.

comment:3 Changed 3 months ago by dgoulet

Status: acceptedneeds_review

comment:4 Changed 3 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm; merged!

comment:5 Changed 3 months ago by cypherpunks

will this be backported to 0.3.2.x? otherwise it will take quite some time to get this to dirauths (mostly running stable)

comment:6 Changed 3 months ago by teor

Keywords: 032-backport-maybe added
Resolution: fixed
Status: closedreopened

comment:7 Changed 3 months ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: 0.3.2.x-final

comment:8 Changed 3 months ago by nickm

Resolution: implemented
Status: reopenedclosed

It looks like a harmless backport, since it only affects strings. Cherry-picked to maint-0.2.9 and merged forward.

Note: See TracTickets for help on using tickets.