#25192 closed defect (invalid)

change of bandwidth accounting intveral from 4 to 24 hours results in unreasonable memory consumption

Reported by: starlight Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor: 0.3.2.9
Severity: Normal Keywords: regression, memory, performance
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The recent change of relay bandwidth reporting has increased the related memory consumption on a mid-size relay from about 200MB to about 1.2GB (i.e. a sixfold increase). The memory dedicated to this function has become unreasonably large.

Child Tickets

Change History (5)

comment:1 Changed 22 months ago by nickm

Keywords: regression memory performance added
Milestone: Tor: 0.3.3.x-final

comment:2 Changed 22 months ago by nickm

The change was made in #23856. It sure wasn't supposed to make memory consumption rise...

comment:3 Changed 22 months ago by nickm

How did you make this analysis? The only memory allocations I can find based on the values that changed in #23856 (commit 8be50ca3ea90ac0) are ones that actually got slightly _smaller_ as a result of the change.

comment:4 Changed 22 months ago by starlight

I made it up in a moment of vein-popping frustration over the inexorable growth of the relay's memory footprint. Seemed like the idea but I didn't check.

Have been seeing 50mb per day of additional memory consumption from four-days onward (now at 8 days). Turned of *all* statistics yesterday and it may have stopped, having increased by only 2MB since. Seems that the attacker is trying something different:

21364 v4 connections
51409 v4 connections
85659 v4 connections
113656 v4 connections
133497 v4 connections
175166 v4 connections
214565 v4 connections
246361 v4 connections
265052 v4 connections
289206 v4 connections
313442 v4 connections
338396 v4 connections
361708 v4 connections
403041 v4 connections
438701 v4 connections
471297 v4 connections
495059 v4 connections
529962 v4 connections
565843 v4 connections
597165 v4 connections
619788 v4 connections
649338 v4 connections
679997 v4 connections
710489 v4 connections
732212 v4 connections
756353 v4 connections
785527 v4 connections

and perhaps this is causing memory growth related to statistics. Didn't look. Can't give this any more time.

comment:5 Changed 22 months ago by starlight

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.