Opened 3 years ago

Closed 3 years ago

#25195 closed enhancement (fixed)

eliminate false-positives for red "This relay is running an outdated Tor version" banner

Reported by: cypherpunks Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


I came up with an idea to eliminate the false-positives when showing the red "This relay is running an outdated Tor version" banner.

Lets only display that red banner if recommended_version is false and 'version' and the version in 'platform' match, otherwise do not display it.


sister ticket: #24974

this is a nice-to-have feature

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by irl

That's clever. The only case I can think of where there would be a false negative is when someone has updated from an outdated relay to another outdated version. I like this.

comment:2 Changed 3 years ago by cypherpunks

Yes, I'm accepting the false-negatives for having nearly 0 false-positives.

comment:3 Changed 3 years ago by irl

Fixed in b186e90. Also the Not Recommended flag will not be added unless the version and platform are consistent.

comment:4 Changed 3 years ago by irl

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.