Opened 2 years ago

Closed 23 months ago

#25199 closed enhancement (fixed)

have a distinct banner for relays running versions newer than what is recommended

Reported by: cypherpunks Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #26700 Points: 0.1
Reviewer: Sponsor:


with #25195 implemented, lets move this banner even further.

we currently say:
"This relay is running an outdated Tor version and should be updated to a recent release of Tor that may contain important fixes."

also on relays running bleeding edge tor code (i.e. nightly builds).

Tor says something more accurate, something like:
"This version of Tor is newer than any recommended version, according to the directory authorities."

lets adopt something like that in atlas as well?
This affects far more relays than #25195 did (currently ~70)

Child Tickets

#24256enhancementclosedkarstenAdd a new "outdated" field to distinguish between outdated and too new tor versions

Change History (10)

comment:1 Changed 2 years ago by cypherpunks

Component: - Select a componentMetrics/Relay Search
Owner: set to metrics-team
Type: defectenhancement

comment:2 Changed 2 years ago by irl

Currently Relay Search does not do any parsing of version numbers, this is all done by Onionoo. Relay Search makes the decision based on whether or not a version is recommended, but doesn't know if the current version is newer or older than recommended versions.

How about if instead, we detect when a version is not a release version (e.g. it's an alpha) and display a distinct banner in that situation. It shouldn't be the case that relays are running that are release versions that are newer than the recommended version. (Maybe there are edge cases and I just didn't spot them?)

comment:3 Changed 2 years ago by arma

See also #24256 for the onionoo side of this idea.

comment:4 Changed 2 years ago by irl

Points: 0.1

Once #25199 is implemented, this should just be a case of checking the new field introduced and displaying a different banner based on that.

comment:5 Changed 2 years ago by iwakeh

Please be aware of the start for RS into Metrics-Web integration and also refer to the branch in this comment of the parent ticket.

comment:6 Changed 2 years ago by irl

#24256 is done, so this is implementable now.

comment:7 Changed 2 years ago by irl

Owner: changed from metrics-team to irl
Status: newaccepted

Expecting to work on this in the next 7 days.

comment:8 Changed 2 years ago by irl

Status: acceptedmerge_ready

Fixed in commit 46aab38 in my relaysearch-dev branch. The "Not Recommended" additional flag is still shown, but the text is updated to make it clear this includes both experimental and obsolete versions.

The new banner for newer than recommended relays will be added in #26667 along with a new Additional Flag.

comment:9 Changed 23 months ago by irl

Parent ID: #26700

comment:10 Changed 23 months ago by irl

Resolution: fixed
Status: merge_readyclosed

Merged in #26700.

Note: See TracTickets for help on using tickets.