Opened 10 months ago

Last modified 3 months ago

#25208 new defect

Relays can upload a new descriptor every 2 minutes

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.3.3.1-alpha
Severity: Normal Keywords: tor-dos-related?, crash?, regression?, 033-triage-20180320, 033-included-20180320, 033-backport, 035-removed-20180711, 034-removed-must-2018-09-05
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description (last modified by teor)

Two relays started publishing descriptors every 2 minutes, and this caused issues for Metrics-lib:
https://lists.torproject.org/pipermail/metrics-team/2018-February/000661.html

Maybe it's a crashing bug in 0.3.3.1-alpha?

In any case, we should probably restrict relays to a few (~6?) descriptors per hour consensus interval, and enforce this limit using the state file.

Child Tickets

Change History (16)

comment:1 Changed 10 months ago by teor

Description: modified (diff)

In test networks, we should use the consensus interval, and not hard-code one hour.

comment:2 Changed 10 months ago by nickm

Keywords: 033-maybe-must added

Mark some tickets as possibly belonging in 033-must.

comment:3 Changed 10 months ago by nickm

Keywords: 033-must added; 033-maybe-must removed

move 033-maybe-must into 033-must

comment:4 Changed 9 months ago by isis

Owner: set to isis
Status: newaccepted

Assigning some 033-must tickets to myself.

comment:5 Changed 9 months ago by nickm

Keywords: regression? added

comment:6 Changed 9 months ago by nickm

Keywords: 033-triage-20180320 added

Marking all tickets reached by current round of 033 triage.

comment:7 Changed 9 months ago by nickm

Keywords: 033-included-20180320 added

Mark 033-must tickets as triaged-in for 0.3.3

comment:8 Changed 9 months ago by arma

Possibly related (and with more hints if so): #25686.

comment:9 Changed 9 months ago by isis

Should we count descriptor uploads in the dirauth state files, or locally on the OR? (I'm inclined to the former so it's not circumventable/gameable.)

comment:10 Changed 9 months ago by isis

arma mentioned that we shouldn't write anything to disk, but simply have dirauth-side rate limits. (I assume we already have functionality for rate-limiting somewhere, but I've never touched that code, so if someone who knows more about it wouldn't mind pointing me in the right direction, that'd be awesome!)

comment:11 Changed 9 months ago by nickm

Keywords: 034-must 033-backport added; 033-must removed
Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Deferring to 0.3.4. Rate-limiting may not be the right answer (Roger says), and suggests that we try to fix the underlying bug instead (#25686?)

comment:12 Changed 9 months ago by isis

Owner: isis deleted
Status: acceptedassigned

Removing myself as owner for now, since I was the owner as part of "everyone take a few 033-must tickets".

comment:13 Changed 7 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: 0.3.5.x-final

no progress during 0.3.4

comment:14 Changed 5 months ago by nickm

Keywords: 035-removed-20180711 added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

These tickets are being triaged out of 0.3.5. The ones marked "035-roadmap-proposed" may return.

comment:15 Changed 5 months ago by teor

Status: assignednew

Make everything that is assigned to no-one new again.

comment:16 Changed 3 months ago by teor

Keywords: 034-removed-must-2018-09-05 added; 034-must removed

These tickets were removed from 0.3.4, so they can't be 034-must.

Note: See TracTickets for help on using tickets.