Opened 3 years ago

Last modified 3 years ago

#25224 new defect

Create a new consensus method that ignores guardfraction votes

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-dirauth, tor-guard, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #24456 Points: 1
Reviewer: Sponsor:


And here is how we remove code that depends on consensus method 20 (the guardfraction method):

  1. Create a new consensus method that ignores guardfraction votes. This new method can go in 034.
  1. Change all the code that says ">= MIN METHOD FOR GUARDFRACTION" to say ">= MIN METHOD FOR GUARDFRACTION and < MIN METHOD TO IGNORE GUARDFRACTION" (the new method). This disables guardfraction when the new method or any later method is used. See consensus method 28 for an example of the code and spec that we need to remove a consensus feature.
  1. When we will never revert to a lower consensus method (two releases later, 036), stop authorities voting for the buggy methods 20-28, and remove a whole bunch of old code, including all the guardfraction code.
  1. At that time, we might want to remove all the methods lower than 20, too. See #24378.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by nickm

Keywords: 034-triage-20180328 added

comment:2 Changed 3 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:3 Changed 3 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.