Opened 3 years ago

Closed 3 years ago

#25231 closed defect (fixed)

Restore metrics-lib submodule in metrics-web

Reported by: iwakeh Owned by: iwakeh
Priority: High Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: karsten Sponsor:

Description

The metrics-lib submodule got corrupted in this commit. This is currently most problematic when checking out from scratch.

I'll add a branch fixing this next.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by iwakeh

Priority: MediumHigh
Reviewer: karsten
Status: assignedneeds_review

Please review this commit.

Steps:

git clone  --branch task-25231 https://git.torproject.org/user/iwakeh/metrics-web.git mw-task-25131
cd mw-task-25131/
./src/main/resources/bootstrap-development.sh

Both the metrics-lib submodule and the metrics-base submodule in metrics-lib should be checked out:

> ls src/submods/metrics-lib/
build.xml  CERT  CHANGELOG.md  CONTRIB.md  LICENSE  README.md  src

> ls src/submods/metrics-lib/src/build/java/
base.xml  build.xml.template  junittest.policy  metrics_checks.xml  stylesheet.css  tor-onion.png

After adding the 'lib' folder (as usual) ant task 'war' should complete successfully.

Setting to high as #25022 depends on this and all other tickets for metrics-web.

comment:2 Changed 3 years ago by iwakeh

Cc: metrics-team added

Adding metrics-team as cc, because the owner list doesn't seem to trigger bug-tracker mails.

comment:3 Changed 3 years ago by iwakeh

Owner: changed from iwakeh, metrics-team to iwakeh
Status: needs_reviewassigned

Changing owner back.

comment:4 Changed 3 years ago by iwakeh

Status: assignedneeds_review

Restoring 'needs_review' setting. (Sorry for all these mails! Just trying to find a way for missing update mails from track. It seems we have to set cc to metrics-team always ...)

comment:5 Changed 3 years ago by karsten

Oops. I'll take a look later today.

comment:6 Changed 3 years ago by karsten

Status: needs_reviewmerge_ready

Looks good. Cherry-picked and pushed to master. If this still looks good, please close. Thanks!

comment:7 Changed 3 years ago by iwakeh

Resolution: fixed
Status: merge_readyclosed

Thanks! All is fine again.
Closing.

Note: See TracTickets for help on using tickets.