Opened 5 months ago

Closed 5 months ago

#25236 closed defect (fixed)

dos: Document torrc default values in the man page when not in the consensus

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-dos, manpage, tor-doc
Cc: Actual Points:
Parent ID: #24902 Points:
Reviewer: nickm Sponsor:

Child Tickets

Change History (10)

comment:1 Changed 5 months ago by dgoulet

Status: assignedneeds_review

Branch: bug25236_029_01

Based on ticket24902_029_05 branch. Once ACK, I'll merge this into that parent branch for the 029 backport.

comment:2 Changed 5 months ago by nickm

lgtm, if you believe that these assertions can't fail.

comment:3 Changed 5 months ago by nickm

ugh, i looked at the wrong branch. hang on...

comment:4 Changed 5 months ago by nickm

s/gonsensus/consensus/;

The documentation for DoSCreationDefenseTimePeriod should use the same template as we use for other INTERVAL values, since it accepts units other than seconds.

Otherwise lgtm!

comment:5 Changed 5 months ago by nickm

(Feel free to merge into ticket24902_029_05 once those issues are resolved)

comment:6 in reply to:  4 Changed 5 months ago by dgoulet

Replying to nickm:

s/gonsensus/consensus/;

The documentation for DoSCreationDefenseTimePeriod should use the same template as we use for other INTERVAL values, since it accepts units other than seconds.

Wait it does not. It is a flat number of seconds. Maybe you got confused with the 1 hour ... I'm removing it.

Otherwise lgtm!

See fixup commit: 3ff67e802c

comment:7 Changed 5 months ago by nickm

But it says this:

  V(DoSCircuitCreationDefenseTimePeriod,   INTERVAL, "0"),

That means that DoSCircuitCreationDefenseTimePeriod 1 hour should work. And in my tests, it does!

comment:8 Changed 5 months ago by dgoulet

Oh oh! Well that is great! How does that look?

Here is a new fixup: 2a16d0a9c2

comment:9 Changed 5 months ago by nickm

lgtm; feel free to squash & merge.

comment:10 Changed 5 months ago by dgoulet

Resolution: fixed
Reviewer: nickm
Status: needs_reviewclosed

Squashed and merged in #24902.

Note: See TracTickets for help on using tickets.