Opened 2 years ago

Closed 2 years ago

#25249 closed defect (fixed)

Spec/implementation deviation in C protover code

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 033-must
Cc: teor Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Our C protover code will reject any attempt to create a protover range ending with UINT32_MAX. But our spec says that we allow that.

I suggest that, since this case is basically unreasonable, we should amend the spec to reject it, and amend the code to reject it explicitly.

Found by Teor.

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by nickm

Keywords: 033-must added

comment:2 Changed 2 years ago by nickm

a8455f4d1a6ef7d2fca1e3cdc1b7b6ee5ce091c7 fixed this in the spec; only the code change remains.

comment:3 Changed 2 years ago by nickm

Resolution: fixed
Status: assignedclosed

1fe0bae508120bbf4954de6b590dd0c722a883bc fixed this in the code; nothing further remains on the original ticket.

Note: See TracTickets for help on using tickets.