Opened 5 months ago

Closed 5 months ago

#25258 closed enhancement (fixed)

Include Relay Search in metrics-web

Reported by: irl Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: #23518 Points:
Reviewer: karsten Sponsor:

Description

  • Create a stub src/main/java/org/torproject/metrics/web/RelaySearchServlet.java to render a JSP
  • Include Relay Search application in src/main/resources/web/rs/
  • Generally all resources should be relative URLs again
  • Add the servlet and a URL mapping to src/main/resources/web.xml

Child Tickets

Change History (8)

comment:1 Changed 5 months ago by irl

Parent ID: #23518

comment:2 Changed 5 months ago by irl

Owner: changed from metrics-team to irl
Status: newaccepted

Looking at this now.

comment:3 Changed 5 months ago by irl

Cc: metrics-team added
Status: acceptedneeds_review

Please review my branches task/25258 for metrics-web and task/25258 for Relay Search. This includes the changes from #25255 but does not include the changes for #25254 (so tooltips on SVGs will not be in the correct place currently).

Before merging to metrics-web the Relay Search branch should be merged and then the submodule in metrics-web updated to point to the primary repository, not my personal repository.

Relay Search is available at:

http://localhost:8080/rs.html

comment:4 Changed 5 months ago by karsten

Reviewer: karsten

I'll take a look.

comment:5 in reply to:  3 Changed 5 months ago by karsten

Status: needs_reviewneeds_revision

Replying to irl:

Please review my branches task/25258 for metrics-web

Looks good!

and task/25258 for Relay Search.

Looks good, as far as I can tell.

This includes the changes from #25255 but does not include the changes for #25254 (so tooltips on SVGs will not be in the correct place currently).

Including #25255 here sounds good. #25254 is merged by now.

Before merging to metrics-web the Relay Search branch should be merged and then the submodule in metrics-web updated to point to the primary repository, not my personal repository.

Do you want to rebase your metrics-web branch to current master and change the submodule definition to point to the official repository? I can hold off pushing anything to metrics-web master for, say, 24 hours. Setting to needs_revision for these small changes only.

Relay Search is available at:

http://localhost:8080/rs.html

I didn't test it now, but the commits reads fine. I'll just assume you tested it, and if anything comes up after merging/deploying, we can fix that quickly.

Thanks!

comment:6 Changed 5 months ago by irl

Status: needs_revisionneeds_review

Cool. I have merged the changes for Relay Search to master, updated the git submodule location, and rebased. This should now be ready for merge.

comment:7 Changed 5 months ago by karsten

Status: needs_reviewmerge_ready

Merged and deployed! I also updated the link on the Services page. Is there anything else I should do? Thanks!

comment:8 Changed 5 months ago by irl

Resolution: fixed
Status: merge_readyclosed

For this ticket then, all is done. Remaining tasks are on #23518.

Note: See TracTickets for help on using tickets.