Opened 7 months ago

Closed 7 months ago

#25266 closed defect (fixed)

PT config should include full names of executable files on Windows

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201802R
Cc: brade, gk, boklm Actual Points:
Parent ID: #24689 Points:
Reviewer: Sponsor:

Description (last modified by mcs)

The Moat client implementation inside Tor Launcher uses Mozilla's Subprocess.jsm module to start the meek client. Mozilla's code requires that we pass in a full path to the program that is to be executed, but the ClientTransportPlugin meek ... line that we append to torrc-defaults does not include the .exe suffix for terminateprocess-buffer or other Windows executable files. We should add the suffixes everywhere for consistency.

Child Tickets

Attachments (1)

0001-Bug-25266-PT-config-should-include-full-names-of-exe.patch (1.8 KB) - added by mcs 7 months ago.
proposed fix

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 months ago by mcs

Description: modified (diff)

comment:2 Changed 7 months ago by mcs

Keywords: TorBrowserTeam201802R added
Status: newneeds_review

Kathy put in a ticket to request a tor-browser-build user repo, but in the meantime I attached a fix to this ticket.

comment:3 Changed 7 months ago by cypherpunks

Summary: PT config should include full names of executable filesPT config should include full names of executable files on Windows

comment:4 Changed 7 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This patch looks good, thanks. I merged it to master as commit 729ad3b42b612829301a1231879296a77c95a35c.

Note: See TracTickets for help on using tickets.