Opened 19 months ago

Last modified 17 months ago

#25273 needs_information defect

tor browser 7.5 fails to download due to silent filename-too-long errors

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

tor browser 7.5 seems to understand how to truncate a title down to 255 bytes for a filename, but then fucks it all up by adding a .html extension and not realizing that it's 260 bytes and then silently botching the download
example:
https://twitter.com/markpopham/status/964157761427787777
load it up, click save, then check the browser console:
Unix error 36 during operation remove on file /tmp/dame judi dench's secret woodland on Twitter: "Every time another one of these mass shootings happen - right when the Republicans start telling us that the answer is more guns, guns for everyone, guns for teachers, guns for students - I think about Chris.html (File name too long) DownloadCore.jsm:2586

Child Tickets

Change History (4)

comment:1 Changed 19 months ago by boklm

Can you reproduce this issue in Firefox 52ESR, or is it specific to Tor Browser ?

comment:2 Changed 19 months ago by cypherpunks

Not the OP, but for completeness' sake here's what happens with 52ESR on Windows 7 (This seems to be specific to Unix systems but I don't have one handy currently to test it out):

https://web.archive.org/web/20180217133043if_/https://imgoat.com/uploads/7e1249ffc0/86064.png

comment:3 Changed 19 months ago by gk

Status: newneeds_information

comment:4 Changed 17 months ago by cypherpunks

just found out it also applies to the applicable %s_files directory exceeding 256 chars

Note: See TracTickets for help on using tickets.