Opened 9 months ago

Closed 8 months ago

#25284 closed defect (implemented)

hidden-service-dir description in dir-spec should reference HSDir protovers

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: fast-fix, easy, doc. prop224, tor-spec, dir-spec, tor-hs, 034-triage-20180328, 034-removed-20180328
Cc: metrics-team Actual Points:
Parent ID: Points: 0.1
Reviewer: dgoulet Sponsor:

Description

Since 0.3.0, tor supports HSDir versions 2 and 3 by default, and advertises no hidden-service-dir VersionNums.

But the spec says:
"If any VersionNum(s) are specified, this router supports those descriptor versions. If none are specified, it defaults to version 2 descriptors"

Child Tickets

Change History (10)

comment:1 Changed 9 months ago by teor

Keywords: tor-hs added

comment:2 Changed 9 months ago by karsten

Cc: metrics-team added

comment:3 Changed 8 months ago by nickm

Keywords: 034-triage-20180328 added

comment:4 Changed 8 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:5 Changed 8 months ago by dgoulet

Woa... damn I wasn't aware of this VersionNum value from the hidden-service-dir line!... Phrack, we should then change the spec or start advertising versions!

But actually, it doesn't seem our code supports VersionNum, it just flags the "ri":

T01("hidden-service-dir",  K_HIDDEN_SERVICE_DIR,  NO_ARGS, NO_OBJ ),
  if (find_opt_by_keyword(tokens, K_HIDDEN_SERVICE_DIR)) {
    router->wants_to_be_hs_dir = 1;
  }

Ok, so maybe removing that VersionNum from the spec is the move and rely solely on protover.

comment:6 Changed 8 months ago by teor

Keywords: easy doc. prop224 added

Hmm, yes, NO_ARGS means Tor has never supported versions in the HSDir line,

So let's revise the spec to say that relays specify their HSDir versions in the proto line, or support v2 if there is no proto line.

Edit: spelling

Last edited 8 months ago by teor (previous) (diff)

comment:7 Changed 8 months ago by teor

Keywords: fast-fix added
Owner: set to teor
Status: newassigned

Please see my branch bug25284 on https://github.com/teor2345/torspec.git

comment:8 Changed 8 months ago by teor

Status: assignedneeds_review

comment:9 Changed 8 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm;

comment:10 Changed 8 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.