Opened 10 months ago

Closed 9 months ago

Last modified 6 months ago

#25304 closed task (fixed)

Update gcc to 6.4.0 (Linux)

Reported by: boklm Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201804R, boklm201804
Cc: Actual Points:
Parent ID: #24631 Points:
Reviewer: Sponsor:

Description

We should build Tor Browser using gcc 6.4.0.

Child Tickets

TicketStatusOwnerSummaryComponent
#20301closedtbb-teamBumping the compiler version to 6.2.0 breaks 64bit Tor Browser buildsApplications/Tor Browser

Change History (8)

comment:1 Changed 10 months ago by boklm

After updating gcc to 6.4.0, gcc fails to build with this error:

g++ -std=gnu++98 -fno-PIE -c   -g -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wm
issing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../.././gcc -I.
./.././gcc/. -I../.././gcc/../include -I../.././gcc/../libcpp/include  -I../.././gcc/../libdecnumber -I../.././gcc/../libdecnumber/bid -I../libdecnumber -I../.././gcc/..
/libbacktrace   -o insn-attrtab.o -MT insn-attrtab.o -MMD -MP -MF ./.deps/insn-attrtab.TPo insn-attrtab.c
g++ -std=gnu++98 -fno-PIE -c   -g -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wm
issing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../.././gcc -I.
./.././gcc/. -I../.././gcc/../include -I../.././gcc/../libcpp/include  -I../.././gcc/../libdecnumber -I../.././gcc/../libdecnumber/bid -I../libdecnumber -I../.././gcc/..
/libbacktrace   -o insn-automata.o -MT insn-automata.o -MMD -MP -MF ./.deps/insn-automata.TPo insn-automata.c
g++ -std=gnu++98 -fno-PIE -c   -g -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wm
issing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../.././gcc -I.
./.././gcc/. -I../.././gcc/../include -I../.././gcc/../libcpp/include  -I../.././gcc/../libdecnumber -I../.././gcc/../libdecnumber/bid -I../libdecnumber -I../.././gcc/..
/libbacktrace   -o insn-dfatab.o -MT insn-dfatab.o -MMD -MP -MF ./.deps/insn-dfatab.TPo insn-dfatab.c
g++ -std=gnu++98 -fno-PIE -c   -g -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wm
issing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../.././gcc -I.
./.././gcc/. -I../.././gcc/../include -I../.././gcc/../libcpp/include  -I../.././gcc/../libdecnumber -I../.././gcc/../libdecnumber/bid -I../libdecnumber -I../.././gcc/..
/libbacktrace   -o insn-latencytab.o -MT insn-latencytab.o -MMD -MP -MF ./.deps/insn-latencytab.TPo insn-latencytab.c
g++ -std=gnu++98    -g -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wmissing-form
at-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -static-libstdc++ -static-libgcc  gc
ov.o \
                hash-table.o ggc-none.o libcommon.a ../libcpp/libcpp.a   ../libbacktrace/.libs/libbacktrace.a ../libiberty/libiberty.a ../libdecnumber/libdecnumber.a  -o
 gcov
/usr/bin/ld.bfd.real: gcov.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
gcov.o: could not read symbols: Bad value
collect2: error: ld returned 1 exit status
make[3]: *** [gcov] Error 1

The gcc build is fixed when setting DEB_BUILD_HARDENING_PIE=0 in projects/gcc/build.

comment:2 in reply to:  1 Changed 10 months ago by cypherpunks

Replying to boklm:

After updating gcc to 6.4.0, gcc fails to build with this error:
...
The gcc build is fixed when setting DEB_BUILD_HARDENING_PIE=0 in projects/gcc/build.

This is #20301.

comment:3 Changed 10 months ago by boklm

Parent ID: #24631

comment:4 Changed 10 months ago by boklm

Keywords: TorBrowserTeam201803 boklm201803 added; TorBrowserTeam201802 boklm201802 removed
Summary: Update gcc to 6.4.0Update gcc to 6.4.0 (Linux)

I created a separate ticket for the Windows gcc update (#25420), to do the Linux and Windows gcc updates separately, as we might not need the Windows one if we switch to clang-cl with #21777.

comment:5 Changed 9 months ago by boklm

Keywords: boklm201804 added; boklm201803 removed

boklm201803 -> boklm201804

comment:6 Changed 9 months ago by boklm

Keywords: TorBrowserTeam201804R added; TorBrowserTeam201803 removed
Status: newneeds_review

There is a patch for review in branch bug_25304_v6:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_25304_v6&id=049196094eeb5a64b6504defaf12e1ab3e2546c3

I checked that the i686, x86_64 and debug builds are running, and their build is reproducible on 2 machines.

comment:7 Changed 9 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to master (commit 049196094eeb5a64b6504defaf12e1ab3e2546c3).

Note: See TracTickets for help on using tickets.