Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#25327 closed defect (fixed)

debug files are not deterministic

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201802R, tbb-rbm, tbb-backported
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

After fixing #24999, when building the 8.0a2 release we noticed that the *-debug.tar.gz files are not deterministic.

It seems that the only difference is in the gzip timestamp, according to the diffoscope output:

--- tor-linux32-debug.tar.gz
+++ ../alpha/unsigned/8.0a2-build2/tor-linux32-debug.tar.gz
├── metadata
│ @@ -1 +1 @@
│ -gzip compressed data, last modified: Wed Feb 21 12:09:06 2018, from Unix
│ +gzip compressed data, last modified: Wed Feb 21 11:41:29 2018, from Unix

We can fix that by using the -n gzip flag:

       -n --no-name
              When compressing, do not save the original file name and time stamp
              by  default.  (The original name is always saved if the name had to
              be truncated.) When decompressing, do not restore the original file
              name  if  present  (remove only the gzip suffix from the compressed
              file name) and do not restore the original time  stamp  if  present
              (copy it from the compressed file). This option is the default when
              decompressing.

An other solution is to create tar.xz files instead of tar.gz. This would also create smaller files.

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by boklm

Keywords: TorBrowserTeam201802R added; TorBrowserTeam201802 removed
Status: newneeds_review

In branch bug_25327 I made a patch creating *-debug.tar.xz files instead of *-debug.tar.gz files:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_25327&id=3699792995ef75ff516fba20b1534e9722ab2f50

comment:2 Changed 5 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, looks good to me. I merged that into master (commit 3699792995ef75ff516fba20b1534e9722ab2f50).

comment:3 Changed 5 months ago by gk

Keywords: tbb-backported added

Forgot to pick that up for 7.5.1 but doing that now with commit 388b7bdc69ad7b39253f70f65fa0d3aa9629d45d on maint-7.5.

Note: See TracTickets for help on using tickets.