Opened 2 years ago

Last modified 5 months ago

#25355 needs_revision enhancement

Add option to set the facility of the syslog log backend dynamically

Reported by: ahf Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-34, 034-triage-20180328, 035-removed-20180711
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Currently it's only possible to change our default syslog facility value if you compile Tor yourself and pass an option to the configure script. It should be possible to set this value, globally for all syslog loggers, in torrc.

Child Tickets

Change History (12)

comment:1 Changed 2 years ago by ahf

Status: newneeds_review

comment:2 Changed 2 years ago by nickm

Keywords: review-group-34 added

comment:3 Changed 2 years ago by dgoulet

Reviewer: mikeperry

Reviewer week 03/19th

comment:4 Changed 2 years ago by mikeperry

Status: needs_reviewneeds_revision

Make check-changes fails. This is listed as a bugfix but it does not mention a version that it is a bugfix on. The changes file should probably just say "Closes ticket 25355".

Also apparently the syslog facility names are not just the things listed in syslog(3). At least on Debian, you have to omit the LOG_ from those strings for them to work.

comment:5 Changed 2 years ago by ahf

Status: needs_revisionneeds_review

Thanks. Should be fixed in the fixup commit.

comment:6 Changed 2 years ago by nickm

Keywords: 034-triage-20180328 added

comment:7 Changed 2 years ago by mikeperry

Status: needs_reviewmerge_ready

Ok lgtm.

comment:8 Changed 2 years ago by nickm

What standard does this conform to? How sure are we that every syslog.h includes CODE and facilitynames?

comment:9 in reply to:  8 Changed 2 years ago by catalyst

Status: merge_readyneeds_revision

Replying to nickm:

What standard does this conform to? How sure are we that every syslog.h includes CODE and facilitynames?

I share this concern about portability. The SYSLOG_NAMES macro, along with facilitynames and the CODE structure, seems to be a Linux (and maybe also macOS?) thing. POSIX says nothing about it.

We should check our assumptions at configure time and have a fallback in case these features aren't available.

comment:10 Changed 2 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: 0.3.5.x-final

Move most needs_revision tickets from 0.3.4 to 0.3.5: we're about to hit the feature freeze.

If you really need to get this into 0.3.4, please drop me a line. :)

comment:11 Changed 2 years ago by nickm

Keywords: 035-removed-20180711 added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

Removing needs_revision tickets from 0.3.5 that seem to be stalled. Please move back if they are under active revision or discussion.

comment:12 Changed 5 months ago by gaba

Reviewer: mikeperry

Remove MikePerry from reviewer from all this old tickets.

Note: See TracTickets for help on using tickets.