#25364 closed enhancement (fixed)

TBA - Create a TOR_BROWSER_VERSION AppConstant

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile
Cc: Actual Points:
Parent ID: #26531 Points:
Reviewer: Sponsor:

Description

The mobile/android/ code doesn't use a preprocessor like the C++ and Javascript code. Instead, there is a class AppConstants containing constant values (and getters) that are set at build time. We will need this for handling when we should do something Tor Browser-specific. Currently Orfox comments large blocks of code, however this isn't easily maintainable and it's not clean, especially if we are (closely) following m-c. If we have a build-time constant, then we can accomplish similar functionality as the mozbuild preprocessor conditional statements.

Child Tickets

Change History (2)

comment:1 Changed 13 months ago by sysrqb

Parent ID: #5709#26531

Required for first alpha.

comment:2 Changed 12 months ago by gk

Resolution: fixed
Status: newclosed

Done in commit b148406e9e358c325e008a22454fe13c416e5789 on tor-browser-60.1.0esr-8.0-1.

Note: See TracTickets for help on using tickets.