#25389 closed defect (fixed)

backport Subprocess.jsm runaway CPU fix (Mozilla 1370027)

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201802R
Cc: brade, gk Actual Points:
Parent ID: #24689 Points:
Reviewer: Sponsor: Sponsor4

Description

It turns out that the Moat runaway CPU issue that gk reported (see ticket:23136#comment:53) is something that Mozilla already found. To fix it in Tor Browser, we need to backport the "Part 1" patch from https://bugzilla.mozilla.org/show_bug.cgi?id=1370027.

Child Tickets

Change History (2)

comment:1 Changed 18 months ago by mcs

Keywords: TorBrowserTeam201802R added
Status: newneeds_review

The Mozilla patch applied cleanly to ESR52 without any changes. Here is the patch:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug25389-01

Kathy and I tested this on Linux and macOS (the changes should not affect Windows), and confirmed that the runaway CPU problem is indeed fixed. We never reproduced the problem on macOS but it was easy to get it to occur on Linux.

comment:2 Changed 18 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Nice find! Looks good and fixes the issue on my end as well. Pushed to tor-browser-52.6.0esr-8.0-2 (commit f7e0d580f4159357cfa3dc69cb9ed4d9027e9b9f).

Note: See TracTickets for help on using tickets.