Opened 3 months ago

Closed 8 weeks ago

#25398 closed defect (implemented)

tests fail if COMPAT_HAS_MMAN_AND_PAGESIZE is not set

Reported by: Hello71 Owned by:
Priority: Low Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: easy, intro, tor-test, review-group-34
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: ahf Sponsor:

Description

tor_mmap_file doesn't check for empty files if COMPAT_HAS_MMAN_AND_PAGESIZE is not set, causes test_util_mmap to fail

Child Tickets

Change History (8)

comment:1 Changed 3 months ago by teor

Keywords: easy intro tor-test added
Milestone: Tor: 0.3.4.x-final
Points: 0.1

comment:2 Changed 3 months ago by Hello71

Status: newneeds_review

https://cgit.alxu.ca/tor.git/commit/?h=bug25398

I think it is better to remove rather than fix. this code doesn't even compile in tests, so clearly nobody actually checks to see if it works.

comment:3 Changed 3 months ago by nickm

(It looks like this code was added for #20530.)

comment:4 Changed 3 months ago by Hello71

if that's the case, I think it would be OK if we apply #25399 first?

comment:5 Changed 3 months ago by nickm

Keywords: review-group-34 added

comment:6 Changed 2 months ago by dgoulet

Reviewer: ahf

Reviewer week 03/16th

comment:7 Changed 2 months ago by ahf

Status: needs_reviewmerge_ready

LGTM. Builds and passes tests on Linux and MinGW too.

comment:8 Changed 8 weeks ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged to master!

Note: See TracTickets for help on using tickets.