Opened 19 months ago

Last modified 16 months ago

#25403 needs_revision enhancement

Create jsp with bgp documentation

Reported by: iwakeh Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: #24229 Points:
Reviewer: Sponsor:

Description

Use the provided html, cf parent ticket.

Child Tickets

Change History (11)

comment:1 Changed 18 months ago by karsten

Owner: changed from metrics-team to karsten
Status: newaccepted

Happy to do this. Is there already an HTML file to convert?

comment:2 Changed 18 months ago by karsten

Status: acceptedneeds_information

comment:3 Changed 18 months ago by iwakeh

Yes, as mentioned in the description: the data and all documentation is here and this is the provided documentation.

comment:4 Changed 18 months ago by karsten

Status: needs_informationneeds_review

My task-25403 branch contains a JSP file that is the result of converting that HTML file. It certainly requires more work, like making it clear that this is an external contribution, moving it around, linking it from other pages, etc. But maybe this is a start.

comment:5 Changed 18 months ago by iwakeh

Status: needs_reviewneeds_revision

We defined the path and url names in the parent, cf. summary in this comment.
I think we should also add a link to the data on CollecTor.

comment:6 Changed 18 months ago by karsten

Owner: changed from karsten to metrics-team
Status: needs_revisionassigned

Ah, I thought this was mainly about making a start by creating a working JSP from the HTML original. I can still make those improvements, but it's unrealistic that I'll do it in the next 1.5 weeks. Reassigning to the team, just in case somebody else wants to pick this up in the meantime.

comment:7 Changed 18 months ago by irl

Please don't put too much effort into styling, as I may end up undoing it all and then doing it again for #25404.

comment:8 Changed 18 months ago by iwakeh

So, actually this could be considered done as soon as the paths (cf. comment:5) are updated and the design fine-tuning is part of #25404?

comment:9 Changed 17 months ago by iwakeh

Status: assignedneeds_review

Please review this fixup commit.

It corrects the path according to this summary and provides the page at localhost:8080/contrib/bgp.html

I also added all data to corsicum. The data is not served yet by Apache. The ticket for the Apache changes is a prerequisite for merging/deploying the jsp.


comment:10 Changed 16 months ago by karsten

Status: needs_reviewneeds_revision

Fixup commit 7767503 looks good. Merged to my task-25403 branch.

Here's what I think is still missing:

  • We need to add a notice to the top of the page saying that it's about contributed data. The page says "we" in several places, and that's a different "we" than on the other pages. With a notice this should be fine, but without that it's confusing. Alternatively, we can add a sentence about who produced this data and change all "we"s to "they"s.
  • The page should contain a link the CollecTor directory containing the data. It does have a link to the script, but not to the data.
  • Our research page needs a new section for contributions, and there needs to be a link to this new page. Right now it's not linked from anywhere and thus won't be found.
  • We'll indeed have to serve the data from CollecTor. Just listing this step here for completeness.
  • Anything else that I forgot?

Thanks for working on this!

comment:11 in reply to:  8 Changed 16 months ago by irl

Replying to iwakeh:

So, actually this could be considered done as soon as the paths (cf. comment:5) are updated and the design fine-tuning is part of #25404?

That sounds good to me. Sorry for taking a while to respond to this question.

Note: See TracTickets for help on using tickets.