Opened 5 months ago

Closed 5 months ago

#25434 closed enhancement (fixed)

Use `ListenAndServeTLS`, not separate `listenTLS` and `Serve` in snowflake-server

Reported by: dcf Owned by: dcf
Priority: Medium Milestone:
Component: Obfuscation/Snowflake Version:
Severity: Normal Keywords:
Cc: dcf, arlolra Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Port these two patches from meek-server to snowflake-server:

This way, we automatically get support for HTTP/2 and whatever TLS settings Go configures by default, rather than copy-pasted settings from some previous version. The only thing we lose is the ability to run a server on port 0; i.e. a random ephemeral port.

Child Tickets

Attachments (1)

bug25434-1.patch (12.2 KB) - added by dcf 5 months ago.

Download all attachments as: .zip

Change History (4)

Changed 5 months ago by dcf

Attachment: bug25434-1.patch added

comment:1 Changed 5 months ago by dcf

Status: assignedneeds_review

Patch for review, pretty much a straight port of the meek commits.

comment:2 in reply to:  description Changed 5 months ago by arlolra

Status: needs_reviewmerge_ready

This way, we automatically get support for HTTP/2 and whatever TLS settings Go configures by default, rather than copy-pasted settings from some previous version. The only thing we lose is the ability to run a server on port 0; i.e. a random ephemeral port.

Seems like a reasonable tradeoff to not have to maintain that duplicated code. Patches LGTM.

Note: See TracTickets for help on using tickets.