Opened 2 years ago

Closed 21 months ago

#25441 closed defect (fixed)

Occasional timing? failures in hs_descriptor/validate_cert unit test

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, rust?, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:


I see failures like this occasionally on a macOS VM when using Rust. Is there some weird timing issue, or is the Rust code interfering with the validation?

hs_descriptor/validate_cert: [forking] 
  FAIL ../src/test/test_hs_descriptor.c:710: assert(ret OP_EQ 1): 0 vs 1
  [validate_cert FAILED]

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by nickm

Keywords: 034-triage-20180328 added

comment:2 Changed 2 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:3 Changed 2 years ago by dgoulet

We use "now" in the test but cert_is_valid() in that test uses approx_time(). This is also kind of related to #25616 for which one solution is to remove that approx time call and instead use the time source from the original caller. And this would fix this issue I bet.

comment:4 Changed 2 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:5 Changed 21 months ago by dgoulet

Resolution: fixed
Status: newclosed

This has been fixed to always use approx_time() or the consensus valid_after time. We shouldn't have this timing failure anymore.

Note: See TracTickets for help on using tickets.