#25444 closed defect (fixed)

Add Apache Commons Codec dependency for java 9

Reported by: iwakeh Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #25443 Points:
Reviewer: irl Sponsor:

Description (last modified by iwakeh)

(see comments)

old version

jaxb dependency needs to be added explicitly when using java 9

The implementation of jaxb is not part of standard java9 se anymore (it is part of java ee).

This can be fixed by adding the 'jaxb-core' jar, which is available as part of debian package 'libjaxb-java'.

Child Tickets

Change History (8)

comment:1 Changed 21 months ago by karsten

I think the only class we're using from that library is javax.xml.bind.DatatypeConverter, and the reason why we're using that is:

commit 1734d1663944acf20d275ac4f66be87d497ab7cb
Author: Karsten Loesing <karsten.loesing@gmx.net>
Date:   Wed Aug 5 13:53:38 2015 +0200

    Remove commons-codec dependency.
    
    Turns out that Java already comes with default implementations of
    SHA-1, SHA-256, and Base64 that we can use.

It was simply convenient that this class existed in Java SE. But before we add a new dependency, maybe we should simply switch back to Apache Commons Codec.

comment:2 Changed 21 months ago by iwakeh

Yes, that's true we removed that dependency a while ago. Let's simply add Apache Commons Codec again.

comment:3 Changed 21 months ago by iwakeh

Description: modified (diff)
Summary: Add jaxb dependency explicitly for java 9Add Apache Commons Codec dependency for java 9

comment:4 Changed 19 months ago by karsten

Priority: LowMedium

comment:5 Changed 18 months ago by karsten

Owner: changed from metrics-team to karsten
Status: newaccepted

comment:6 Changed 18 months ago by karsten

Status: acceptedneeds_review

comment:7 Changed 17 months ago by irl

Reviewer: irl
Status: needs_reviewmerge_ready

Looks good to me.

comment:8 Changed 17 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks for looking! Merged to master and closing.

Note: See TracTickets for help on using tickets.