Opened 9 months ago

Closed 5 months ago

#25448 closed enhancement (implemented)

allow for URLs that specify list of fingerprints

Reported by: cypherpunks Owned by: karsten
Priority: Low Milestone: Onionoo 1.16.0
Component: Metrics/Onionoo Version:
Severity: Minor Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: irl Sponsor:

Description

context:
https://lists.torproject.org/pipermail/metrics-team/2018-March/000709.html

url could look like:
..fp=fp1,fp2,..

Also allow specifying the number of shown items per page.

consider this a low prio request (nothing happens if you don't implement it)

Child Tickets

Change History (11)

comment:1 Changed 9 months ago by karsten

Let's consider implementing this in Onionoo, not Relay Search.

comment:2 in reply to:  1 Changed 9 months ago by irl

Component: Metrics/Relay SearchMetrics/Onionoo

Replying to karsten:

Let's consider implementing this in Onionoo, not Relay Search.

I'm always for having things in Onionoo to keep Relay Search simpler.

comment:3 Changed 5 months ago by karsten

Cc: metrics-team added
Owner: changed from metrics-team to karsten
Status: newaccepted

How about we extend Onionoo's "lookup" parameter to support a list of comma-separated fingerprints in addition to a single fingerprint?

This should be quite simple to build while I'm looking into #23713 and #23914, so I'm just adding this to my list, too.

comment:4 Changed 5 months ago by karsten

Status: acceptedneeds_review

comment:5 Changed 5 months ago by irl

Reviewer: irl

comment:6 Changed 5 months ago by irl

Status: needs_reviewneeds_revision

Is there a reason that we can't have the fingerprint parameter accept a list just as lookup does is in this patch?

comment:7 Changed 5 months ago by karsten

Oh, yes, the yet unspoken reason that we shouldn't keep both parameters. I meant to create a ticket for that, but forgot. Let me do that now, so that we can discuss the future of the fingerprint parameter, and then we can get back to this ticket.

comment:8 in reply to:  7 Changed 5 months ago by karsten

Replying to karsten:

Oh, yes, the yet unspoken reason that we shouldn't keep both parameters. I meant to create a ticket for that, but forgot. Let me do that now, so that we can discuss the future of the fingerprint parameter, and then we can get back to this ticket.

Created #26919.

comment:9 in reply to:  7 Changed 5 months ago by irl

Status: needs_revisionneeds_review

Replying to karsten:

Oh, yes, the yet unspoken reason that we shouldn't keep both parameters. I meant to create a ticket for that, but forgot. Let me do that now, so that we can discuss the future of the fingerprint parameter, and then we can get back to this ticket.

Ah ok. I didn't even realise we had that field until I saw it in the commit.

In which case, I shall finish the review.

comment:10 Changed 5 months ago by irl

Status: needs_reviewmerge_ready

Looks good to me.

comment:11 Changed 5 months ago by karsten

Milestone: Onionoo 1.16.0
Resolution: implemented
Status: merge_readyclosed

Cool! Merged to master. Adding to the Onionoo 1.16.0 milestone as a reminder to document the change in metrics-web when putting out the next release. Closing. Thanks!

Note: See TracTickets for help on using tickets.