UI customization half-broken in Tor Browser 8.0a3

seen with Tor Browser 8.0a3-build1 on Linux (64 bit)

Changing the UI via the menu entry "Customize" does not work anymore because the customization view closes immediately after opening, so drag-and-drop is impossible. Right-clicking on a menu entry and selecting "Move to Toolbar" still works, as well as "Move to Menu" for something which was moved to the toolbar.

Maybe #25147 (moved) is the reason.

Trac:
Username: viktorj

added TorBrowserTeam201804R component::applications/tor browser owner::pospeselr parent::25147 priority::medium reporter::viktorj resolution::fixed severity::major status::closed tbb-regression type::defect labels

You shipped it, ignoring tor-qa, so hrm...

Trac:
Parent: N/A to #25147 (moved)
Priority: Medium to High
Severity: Normal to Major
Keywords: N/A deleted, tbb-regression added

Strange, I can't reproduce the issue myself (linux 64 bit as well)...

Reproducible on Windows:

16:54:02.700 CustomizeMode:Error entering customize mode TypeError: messageNode.querySelector(...) is null
Stack trace:
CustomizeMode.prototype.maybeShowTip@re[//modules/CustomizeMode.jsm:701:7](//modules/CustomizeMode.jsm:701:7)
CustomizeMode.prototype.enter/<@re[//modules/CustomizeMode.jsm:358:7](//modules/CustomizeMode.jsm:358:7)
TaskImpl_run@re[/gre/modules/Task.jsm:319:42](/gre/modules/Task.jsm:319:42)
Handler.prototype.process@re[/gre/modules/Promise.jsm](/gre/modules/Promise.jsm) -> re[/gre/modules/Promise-backend.js:932:23](/gre/modules/Promise-backend.js:932:23)
this.PromiseWalker.walkerLoop@re[/gre/modules/Promise.jsm](/gre/modules/Promise.jsm) -> re[/gre/modules/Promise-backend.js:813:7](/gre/modules/Promise-backend.js:813:7)
this.PromiseWalker.scheduleWalkerLoop/<@re[/gre/modules/Promise.jsm](/gre/modules/Promise.jsm) -> re[/gre/modules/Promise-backend.js:747:11](/gre/modules/Promise-backend.js:747:11)
 1 CustomizeMode.jsm:374

Trac:
Keywords: N/A deleted, TorBrowserTeam201803 added

Yeah, I can reproduce it now with a fresh clean install of Tor Browser 8.0a4

Trac:
Username: franklin
Cc: N/A to franklin

Not sure how related but BTW the entire UI becomes sometimes completely unresponsive, and one has to wait quiet a bit before it gets back to normal.

Moving our tickets to April.

Trac:
Keywords: TorBrowserTeam201803 deleted, TorBrowserTeam201804 added

Trac:
Priority: High to Medium

Trac:
Status: new to assigned
Owner: tbb-team to pospeselr

Trac:
Cc: franklin to franklin, tbb-team

Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201804 deleted, TorBrowserTeam201804R added

So, that fix in grid.js is not directly related to the customization basically broken, right? Or, if it is related to that how do I trigger that breakage, because it seems I am failing to do so.

Trac:
Status: needs_review to needs_information

Trac:
0001-Bug-25458-UI-customization-half-broken-in-Tor-Browse.patch

Trac:
Status: needs_information to needs_review

Looks good now, thanks. Applied to tor-browser-52.7.3esr-8.0-1 (commit 12847934f5c7baf4e94945ec433f1b2fdcf33625).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#25458 (closed)