Opened 9 months ago

Last modified 5 weeks ago

#25475 needs_review enhancement

TB Credits

Reported by: arthuredelstein Owned by: traumschule
Priority: Medium Milestone: website redesign
Component: Webpages/Website Version:
Severity: Normal Keywords:
Cc: tbb-team, alison, antonela, daniela, emmapeel, hiro Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should have a page of contributors, either on the website or Tor browser. Tor Community members, translators etc

Child Tickets

Change History (14)

comment:1 Changed 9 months ago by gk

Component: - Select a componentWebpages/Website

Having this on the website sounds like a good idea as this does not seem to be a Tor Browser-only thing. (However, I think having a credits page for specific Tor Browser contributions inside Tor Browser seems to be a thing we could want to have, too.)

comment:2 Changed 9 months ago by hiro

Milestone: website redesign

comment:3 Changed 4 months ago by traumschule

Owner: set to traumschule
Status: newassigned

I think this is important. One approach is to list contributors one page based on the existing projects lists. I remember a neat guide on github to represent all people active in a project not only coders (implementations: all-contributors-cli and github-contributors-list). With respect to the long list of repositories. This could become quite comprehensive.

Assigning ti myself to not forget about it after the TBB 8 release. If I do, please grab it.

Last edited 3 months ago by traumschule (previous) (diff)

comment:4 Changed 3 months ago by traumschule

Status: assignedneeds_information

When i wondered how to collect all contributors and came across
https://github.com/arthuredelstein/tor-browser/graphs/contributors
https://github.com/torproject/tor/graphs/contributors

i also tried git log --pretty=oneline --format="%an <%ae>" on tor-browser.git but it gave me 364263 lines with a lot of duplicates. Also uniq -D did not help much. Maybe someone else has an idea.

What would be the best way all contributors on a page, sorted by the number of commits like on the GH page? Maybe an AUTHORS file in the repository?

update: github announced to depreacte some of their services, this could affect the v3 api for contributors.

Last edited 3 months ago by traumschule (previous) (diff)

comment:5 Changed 3 months ago by traumschule

Status: needs_informationassigned

ok, i'll create a file listing all contributors in alphabetical order. if we want to be more specific we have something to build upon. happy to read your ideas!

comment:6 Changed 3 months ago by arma

Credits for what?

Tor has many umbrella projects -- is the idea to just make a page that is a jumble of all the contributors of all the projects?

It seems like each project should handle its own credits.

comment:7 Changed 3 months ago by traumschule

Summary: Credits pageTB Credits

I was thinking of tor browser as in the description, either for a section on the tb page with a link from the download page, or on a separate one. But from my understanding the list has to be created first (to be added to the repository as well), so the final destination may stay undefined until then.
edit: just found http://dissociatedpress.net/stop-using-github-as-a-measure-of-open-source-contributions/

Last edited 3 months ago by traumschule (previous) (diff)

comment:8 Changed 3 months ago by asn

.oO(I want the credits to come out with an easter egg. old school style.)

comment:9 Changed 3 months ago by traumschule

Cc: tbb-team added
Status: assignedneeds_information

Shall we also show the email address?
Should the list be sorted alphabetically instead?
Should it link projects that are part of the bundle like tor and PTs?

My instinctive answer is to add an AUTHORS / CONTRIBUTORS file to each repository and list the projects with a link to git at the end.

Tor Browser since 2016

List of committers since 2016 sorted by the number of commits.

Authors
Nicolas Vigier
Georg Koppen
Sukhbir Singh
David Fifield
Arthur Edelstein
Kathy Brade
Richard Pospesel

Contributors
Tom Ritter
William Budington
Sina Rabbani
Patrick O'Doherty
Isis Lovecruft
Igor Oliveira
Ben Burrill
Arlo Breault

Parts / Previous

https://gitweb.torproject.org/tor-browser-spec.git/
https://gitweb.torproject.org/torbutton.git/
https://gitweb.torproject.org/tor-launcher.git/
https://gitweb.torproject.org/tor-browser.git/
https://gitweb.torproject.org/pluggable-transports/
https://gitweb.torproject.org/builders/rbm.git/

https://gitweb.torproject.org/vidalia.git/
https://gitweb.torproject.org/builders/gitian-builder.git/

Script

git log --pretty=oneline --format="%an"|sort|uniq -c|sort -gr|cut -c9-

comment:10 in reply to:  9 ; Changed 3 months ago by arthuredelstein

Replying to traumschule:

Thank you for looking into this, traumschule! :)

Shall we also show the email address?

No, I don't think people should be rewarded for their efforts with spam. :)

Should the list be sorted alphabetically instead?

Yes, I like this idea. I don't think we should try to separate "authors" from "contributors" because the distinction is unclear.

Should it link projects that are part of the bundle like tor and PTs?

I think so!

My instinctive answer is to add an AUTHORS / CONTRIBUTORS file to each repository and list the projects with a link to git at the end.

https://gitweb.torproject.org/builders/tor-browser-build.git/

There are a lot of Tor Browser-related repositories, so we'll need to look at committers of all sorts. Also, many people have contributed very important ways, including design, translation, testing, admin, community building, documentation, metrics, etc. We should give all people involved credit for their efforts because they help make Tor Browser possible. Also, I would like to give credit to our Mozilla collaborators who have contributed so much to our anti-tracking and cross-compilation efforts.

And, given that Tor Browser is the product that most people download, I would propose including contributors to core Tor as well. Let's be inclusive as we can!

We could consider adding some (brief) information about what each person has done. Such as "design", "metrics", "Tor Browser", "tor", "Spanish translation", etc.

comment:11 in reply to:  10 Changed 2 months ago by traumschule

Replying to arthuredelstein:

Shall we also show the email address?

No, I don't think people should be rewarded for their efforts with spam. :)

Should the list be sorted alphabetically instead?

Yes, I like this idea. I don't think we should try to separate "authors" from "contributors" because the distinction is unclear.

Great, this makes it simple: git shortlog --format='%an' -s|cut -c8-|sort. To avoid appearance of the same person with different name notations the .mailcap feature can help (git help shortlog).

Should it link projects that are part of the bundle like tor and PTs?

I think so!

My instinctive answer is to add an AUTHORS / CONTRIBUTORS file to each repository and list the projects with a link to git at the end.

https://gitweb.torproject.org/builders/tor-browser-build.git/

There are a lot of Tor Browser-related repositories, so we'll need to look at committers of all sorts. Also, many people have contributed very important ways, including design, translation, testing, admin, community building, documentation, metrics, etc. We should give all people involved credit for their efforts because they help make Tor Browser possible. Also, I would like to give credit to our Mozilla collaborators who have contributed so much to our anti-tracking and cross-compilation efforts.

And, given that Tor Browser is the product that most people download, I would propose including contributors to core Tor as well. Let's be inclusive as we can!

We could consider adding some (brief) information about what each person has done. Such as "design", "metrics", "Tor Browser", "tor", "Spanish translation", etc.

This is the tricky part and i have the feeling a wiki page might be better suited to collect all project links and working areas. What do you think about if we use doc/TorBrowser/Contributors as a start? I would take care to fill it over time and start asking around how people want to be listed, or at best everyone can change their entry at will.

edit: i wrote a script that a created a file with ~6000 names. in the end the list could look like this https://www.mozilla.org/credits/

Last edited 2 months ago by traumschule (previous) (diff)

comment:12 Changed 5 weeks ago by traumschule

Cc: alison antonela daniela emmapeel hiro added
Status: needs_informationneeds_review
Type: defectenhancement

First draft: Tor Browser contributors

How shall we proceed to create a more or less complete list of non-code contributors?

comment:13 in reply to:  12 ; Changed 5 weeks ago by boklm

Replying to traumschule:

First draft: Tor Browser contributors

It seems tor-browser includes the lists of all firefox contributors, which is a very big list. Maybe we could list only the authors of Tor Browser patches and add a link to https://www.mozilla.org/credits/ ?

comment:14 in reply to:  13 Changed 5 weeks ago by traumschule

Replying to boklm:

It seems tor-browser includes the lists of all firefox contributors, which is a very big list. Maybe we could list only the authors of Tor Browser patches and add a link to https://www.mozilla.org/credits/ ?

This sounds like a good idea but i don't know how to only select our commits. Do you have a hint?

Also several names are doubled in different variations and it's a lot of work to merge them with .mailmap files in each repository. I have the feeling this is beyond the scope of this ticket and would require individual issues for each project.

Note: See TracTickets for help on using tickets.