Opened 3 months ago

Closed 32 hours ago

#25477 closed defect (implemented)

Stop warning users about bug #21018

Reported by: asn Owned by: rl1987
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, tor-client, 034-triage-20180328, 034-removed-20180328 034-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

While working on #14389 we figured out that when a Tor client connects to an onion service with authorization without the proper authorization client config (or non-existent auth config), Tor will throw out 6 warnings like this:

 [warn] Failed to parse introduction points. Either the service has published a corrupt descriptor or you have provided invalid authorization data, or (maybe!) the server is deliberately serving broken data in an attempt to crash you with bug 21018.

We should consider removing the alarmist warn about bug #21018 at some point, and maybe that point is now, since it might freak out users for no reason and there is no way for us to learn whether the attack took place.

Child Tickets

Change History (9)

comment:1 Changed 3 months ago by nickm

Keywords: 034-triage-20180328 added

comment:2 Changed 3 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:3 Changed 2 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:4 Changed 3 weeks ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:5 Changed 3 weeks ago by rl1987

Status: acceptedneeds_review

comment:6 Changed 3 weeks ago by nickm

Keywords: 034-backport added
Milestone: Tor: unspecifiedTor: 0.3.5.x-final

comment:7 Changed 13 days ago by dgoulet

Reviewer: asn

comment:8 Changed 11 days ago by asn

Status: needs_reviewmerge_ready

LGTM.

comment:9 Changed 32 hours ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.