Opened 8 months ago

Closed 2 months ago

#25505 closed defect (fixed)

Netflow padding should inspect circuitmux queues

Reported by: mikeperry Owned by: mikeperry
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 032-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

The netflow padding code only tries to transmit padding if the link is otherwise idle. Dgoulet pointed out that checking the channel outbuf is not enough -- since kist that is now mostly empty. We need to inspect the circuitmux queue also.

Child Tickets

Change History (11)

comment:1 Changed 8 months ago by mikeperry

Status: assignedneeds_review

mikeperry/bug25505.

comment:2 Changed 3 months ago by nickm

Component: Core TorCore Tor/Tor

comment:3 Changed 3 months ago by nickm

Milestone: Tor: 0.3.5.x-final

geez, looks like we missed this because it didn't have a milestone.

comment:4 Changed 3 months ago by nickm

Owner: set to mikeperry
Status: needs_reviewassigned

Setting owner too.

comment:5 Changed 3 months ago by nickm

Status: assignedneeds_review

comment:6 Changed 3 months ago by asn

Reviewer: dgoulet

comment:7 Changed 3 months ago by dgoulet

Status: needs_reviewmerge_ready

lgtm;

comment:8 Changed 2 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merging to 0.3.5. If this should be backported to some earlier branch please reopen and let me know.

comment:9 Changed 2 months ago by mikeperry

Keywords: 032-backport added
Resolution: fixed
Status: closedreopened

Dgoulet is in favor of backport as far back as 032 (or whenever the last branch was that had kist that we will keep maintaining).

comment:10 Changed 2 months ago by nickm

Let's say 0.3.3? 0.3.2 is EOL in October.

comment:11 Changed 2 months ago by nickm

Resolution: fixed
Status: reopenedclosed

Backported to 0.3.3 and merged forward to 0.3.4

Note: See TracTickets for help on using tickets.