Opened 2 years ago

Closed 2 years ago

#25516 closed task (implemented)

Refactor relay cell crypto into a new relaycrypt.c

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-cell, crypto, refactor, tor-testing, tor-modularity, 034-triage-20180328
Cc: isis, Samdney Actual Points: .5
Parent ID: Points: .5
Reviewer: asn Sponsor: Sponsor3-can


The functions relay_crypt, relay_crypt_one_payload, and relay_init_cpath_crypto, as well as extractable parts of onionskin_answer and circuit_free_cpath_node -- belong in their own conceptual module. Considered as such, they become fairly easy to test.

We have identified this work as valuable for modularization, for testing, and potentially valuable for testing future relay crypto designs.

Child Tickets

Change History (9)

comment:1 Changed 2 years ago by isis

Cc: isis added
Keywords: tor-cell crypto refactor tor-testing tor-modularity added

comment:2 Changed 2 years ago by nickm

Status: assignedaccepted

comment:3 Changed 2 years ago by nickm

Actual Points: .5
Status: acceptedneeds_review

I now have a branch for this, called split_relay_crypto. It also improves our test coverage a little.

comment:4 Changed 2 years ago by nickm

Keywords: 034-triage-20180328 added

comment:5 Changed 2 years ago by Samdney

Cc: Samdney added

comment:6 Changed 2 years ago by asn

Reviewer: asn

comment:7 Changed 2 years ago by asn

Status: needs_reviewmerge_ready


5ecad6c95d took a while to review. In general the branch looks legit and I like the new changes!

comment:8 Changed 2 years ago by nickm

Great; it's merged to master!

comment:9 Changed 2 years ago by nickm

Resolution: implemented
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.