Opened 2 years ago

Closed 2 years ago

#25517 closed defect (fixed)


Reported by: isis Owned by: isis
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: trove, 033-must, security, 033-triage-20180320, 033-included-20180320
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description (last modified by nickm)

Tracking issue for TROVE-2018-005.

(The bug here is a memory-related denial-of-service attack, but only applies to directory authorities. They've all been informed.)

Child Tickets

Change History (14)

comment:1 Changed 2 years ago by nickm

Milestone: Tor: 0.3.3.x-final

comment:2 Changed 2 years ago by nickm

Keywords: 033-must security added

comment:3 Changed 2 years ago by nickm

Keywords: 033-triage-20180320 added

Marking all tickets reached by current round of 033 triage.

comment:4 Changed 2 years ago by nickm

Keywords: 033-included-20180320 added

Mark 033-must tickets as triaged-in for 0.3.3

comment:5 Changed 2 years ago by nickm

Owner: set to isis
Status: newassigned

comment:6 Changed 2 years ago by isis

Status: assignedneeds_review

Please review! See the patchset in the TROVE-2018-005 thread on the security list.

comment:7 Changed 2 years ago by nickm

Status: needs_reviewneeds_revision

I agree with Teor's comments on that thread. Additionally, it needs a changes file. Then I think it should be good to go!

comment:8 Changed 2 years ago by nickm

On further thought, I'm no longer sure I agree about needing a new consensus method here. I'll send email later.

comment:9 Changed 2 years ago by isis

Status: needs_revisionneeds_review

Consensus method 29 added, and a way to be backwards compatible with older consensus methods. I'll send the torspec patch to the security list as well.

comment:10 Changed 2 years ago by dgoulet

Reviewer: nickm

comment:11 Changed 2 years ago by nickm

Status: needs_reviewmerge_ready

I'm calling this merge-ready, but I have open questions and comments in my most recent email to network-team-security@.

For timing reasons discussed there, I believe the best time to apply this fix is once we are comfortable asking authorities to all run 0.3.3.

comment:12 Changed 2 years ago by nickm

Description: modified (diff)
Milestone: Tor: 0.3.3.x-finalTor: 0.3.2.x-final

Okay, we've finally got this ready. I've merged trove-2018-005_033 to maint-0.3.3, and trove-2018-005-034 to master. I have trove-2018-005_032 sitting ready for a backport to maint-0.3.2, if we decide to do that.

comment:13 Changed 2 years ago by nickm

I ran into a compilation error on windows, and fixed it with 240bb177140099690213dfc524a235abd2aa0eb8

comment:14 Changed 2 years ago by teor

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final
Resolution: fixed
Status: merge_readyclosed

We won't backport to 0.3.2, because all authorities except the bridge authority are running 0.3.3 now.

Note: See TracTickets for help on using tickets.