#25520 closed enhancement (fixed)

Adapt webstats to read CollecTor provided logs

Reported by: iwakeh Owned by: karsten
Priority: High Milestone:
Component: Metrics/Statistics Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: iwakeh Sponsor:

Description

CollecTor log names and paths differ slightly from the current setup.
Webstats statistics need to be generated from the new data.

Child Tickets

Change History (9)

comment:1 Changed 21 months ago by iwakeh

Cc: metrics-team added
Owner: changed from metrics-team to iwakeh
Status: newaccepted

comment:2 Changed 21 months ago by karsten

Oh, wait, I started hacking on this after we talked yesterday. Mind picking something else for now?

comment:3 Changed 21 months ago by iwakeh

Fine, this is down on a list, so you can just grab the ticket.

comment:4 Changed 21 months ago by karsten

Owner: changed from iwakeh to karsten

Grabbing.

comment:5 Changed 20 months ago by karsten

Priority: MediumHigh
Reviewer: iwakeh
Status: acceptedneeds_review

Please review commit 4ca4df9 from my task-25520 branch.

Optimistically assigning iwakeh as reviewer. :)

Setting priority to high, because I'd really like to cross this off the list by end of the month.

comment:6 Changed 20 months ago by iwakeh

Status: needs_reviewneeds_revision

The webstats/MainTest fails. Maybe, remove or replace by other tests (it seems to test log line parsing, which is done in metrics-lib now).

Please take a look at this patch.
I tweaked the use of streams a little. Log line counts could be bigger than integer: use long in java and bigint in sql. If you think that it suffices to use int (and don't want to alter the db table) please introduce a cast to int at before writing to the db.

comment:7 in reply to:  6 Changed 20 months ago by karsten

Status: needs_revisionneeds_review

Replying to iwakeh:

The webstats/MainTest fails. Maybe, remove or replace by other tests (it seems to test log line parsing, which is done in metrics-lib now).

Hmm, you're right. Everything's tested in metrics-lib, so we can just remove this test.

Please take a look at this patch.
I tweaked the use of streams a little. Log line counts could be bigger than integer: use long in java and bigint in sql. If you think that it suffices to use int (and don't want to alter the db table) please introduce a cast to int at before writing to the db.

Looks good. I'll alter the database table as part of deployment.

Please find my updated branch with your commit and with the removed test class. I think I'd like to squash all three commits into one, unless you think that's a bad idea.

comment:8 Changed 20 months ago by iwakeh

Status: needs_reviewmerge_ready

Looks fine and can be just one commit.

comment:9 Changed 20 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Great! Squashed and merged. Will deploy later today. Closing. Thanks!

Note: See TracTickets for help on using tickets.