Adapt webstats to read CollecTor provided logs
CollecTor log names and paths differ slightly from the current setup. Webstats statistics need to be generated from the new data.
Activity
Please review commit 4ca4df9 from my task-25520 branch.
Optimistically assigning iwakeh as reviewer. :)
Setting priority to high, because I'd really like to cross this off the list by end of the month.
Trac:
Priority: Medium to High
Status: accepted to needs_review
Reviewer: N/A to iwakeh
The webstats/MainTest fails. Maybe, remove or replace by other tests (it seems to test log line parsing, which is done in metrics-lib now).
Please take a look at this patch. I tweaked the use of streams a little. Log line counts could be bigger than integer: use long in java and bigint in sql. If you think that it suffices to use int (and don't want to alter the db table) please introduce a cast to int at before writing to the db.
Trac:
Status: needs_review to needs_revision-
Replying to iwakeh:
The webstats/MainTest fails. Maybe, remove or replace by other tests (it seems to test log line parsing, which is done in metrics-lib now).
Hmm, you're right. Everything's tested in metrics-lib, so we can just remove this test.
Please take a look at this patch. I tweaked the use of streams a little. Log line counts could be bigger than integer: use long in java and bigint in sql. If you think that it suffices to use int (and don't want to alter the db table) please introduce a cast to int at before writing to the db.
Looks good. I'll alter the database table as part of deployment.
Please find my updated branch with your commit and with the removed test class. I think I'd like to squash all three commits into one, unless you think that's a bad idea.
Trac:
Status: needs_revision to needs_review