Opened 8 months ago

Closed 6 months ago

#25548 closed defect (fixed)

Update macOS SDK for Tor Browser builds to 10.11

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff60-esr, GeorgKoppen201805, TorBrowserTeam201806R
Cc: mcs, brade Actual Points:
Parent ID: #24632 Points:
Reviewer: Sponsor:

Description

We need for ESR60-based Tor Browsers a newer macOS SDK.

Child Tickets

Change History (7)

comment:1 Changed 8 months ago by gk

Cc: mcs brade added

mcs, brade: Do you have by chance a system with a 10.11 SDK available somewhere? It would be neat if we could extract it ourselves instead of relying on some random one found on the Internet. The instructions to create the one we need are probably:

# This SDK was copied from a local XCode install and uploaded to tooltool.
# Generate the tarball by running this command with the proper SDK version:
#   sdk_path=$(xcrun --sdk macosx10.12 --show-sdk-path)
#   tar -C $(dirname ${sdk_path}) -cHjf /tmp/$(basename ${sdk_path}).tar.bz2 $(basename ${sdk_path})

(see: https://dxr.mozilla.org/mozilla-central/source/build/macosx/cross-mozconfig.common)

comment:3 Changed 7 months ago by gk

Keywords: tbb-rbm added

comment:4 Changed 6 months ago by gk

Keywords: TorBrowserTeam201805 GeorgKoppen201805 added
Priority: MediumVery High

comment:5 Changed 6 months ago by gk

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201805 removed
Status: newneeds_review

comment:6 Changed 6 months ago by gk

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201805R removed

Moving review tickets to June.

comment:7 Changed 6 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good to me. I merged branch bug_25548_v2 to master with commit 90aa993289db466f928244443d2acdf6c8a2652d.

Note: See TracTickets for help on using tickets.