Opened 7 months ago

Closed 4 months ago

#25554 closed defect (fixed)

Bump mingw-w64 version for ESR 60

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff60-esr, TorBrowserTeam201806R
Cc: sukhbir Actual Points:
Parent ID: #26203 Points:
Reviewer: Sponsor:

Description

We need a newer mingw-w64 version to be able to build Tor Browser based on Firefox 60 ESR.

Child Tickets

Change History (9)

comment:1 Changed 6 months ago by gk

Keywords: tbb-rbm added

comment:2 Changed 6 months ago by gk

Keywords: TorBrowserTeam201804R added
Status: newneeds_review

The version in bug_25554 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_25554&id=886597792c7b499745145b13b050d86df8e3f5e1) works for me and would work with a clang/mingw-w64 toolchain as far as we know.

This should get reviewed once we switched to an ESR60 tor-browser branch.

comment:3 Changed 6 months ago by gk

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201804R removed

Moving review tickets to May.

comment:4 Changed 5 months ago by gk

Keywords: TorBrowserTeam201805 added; TorBrowserTeam201805R removed
Status: needs_reviewneeds_revision

We want to have at least d7bee3f20e7978270aef15c8cee0256af48d108f.

comment:5 Changed 5 months ago by gk

Cc: sukhe added
Parent ID: #24631#26203

comment:6 Changed 5 months ago by gk

Priority: MediumVery High

comment:7 Changed 5 months ago by gk

Cc: sukhbir added; sukhe removed

CCing the real sukhe

comment:8 Changed 4 months ago by gk

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201805 removed
Status: needs_revisionneeds_review

Okay, let#s get back here. I think we want to bump mingw-w64 to ee9fc3d0b8c8868280e38384edd968067b8e71fc. This is done with my patch in bug_25554_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_25554_v2&id=4c1f78c312aa10ff54e5b07de4ef3278ab2ed01e).

comment:9 Changed 4 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good to me. I merged this to master with commit ddc77b4d679b3027924b89350dce9b672967e625.

Note: See TracTickets for help on using tickets.