#25561 closed enhancement (fixed)

Update TBB User Agent String for detecting Orfox

Reported by: sysrqb Owned by: arlolra
Priority: Medium Milestone:
Component: Applications/Tor Check Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A few years ago, Check began detecting Orfox via its User Agent String with [0] and then [1]. As it turns out, now we want the logic in [0] again.

[0] https://gitweb.torproject.org/check.git/commit/?id=749fd988c32e764e7fc8dde1f59ab7f06a63f0cd
[1] https://gitweb.torproject.org/check.git/commit/?id=644e1c21b682a911acbea567f55d156a084a8c5f

Child Tickets

Attachments (1)

0001-Match-Tor-Browser-and-new-Orfox-UAS-together.patch (2.2 KB) - added by sysrqb 12 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 months ago by sysrqb

Status: newneeds_review

Orfox should have a new release coming out soon, so ideally Check will correctly detect it. Originally I wrote a patch that only detects the new Orfox UAS, but this version is nicer and detects both the old version and the new version. Someone (maybe me) should file a new ticket in a few weeks (or sooner) for ripping out the old Orfox-specific pattern.

comment:2 Changed 12 months ago by n8fr8

Thoughts on how long this will take to deploy?

Juts wondering if I should hold the Orfox release to wait for it.

comment:3 Changed 12 months ago by arlolra

Resolution: fixed
Status: needs_reviewclosed

This was merged as https://gitweb.torproject.org/check.git/commit/?id=aa25675a220bc91104fd887216d09314ca26c822

Thoughts on how long this will take to deploy?

Done

Note: See TracTickets for help on using tickets.