Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#25562 closed enhancement (fixed)

Update Tor Browser Hacking page with Orfox instructions

Reported by: sysrqb Owned by: sysrqb
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201804
Cc: gk, igt0 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Following #19675, we should update the build/hacking instructions for Orfox. We already have some information igt0 added, but now we can say "build TB alpha" (tor-browser-52.7.2esr-8.0-1). Unfortunately, it's not really that simple.

I wonder if we should amend the "Building Orfox" part on our Hacking document a
bit to reflect the new situation. FWIW: I needed to spent quite some time to
get the Android SDK thing to do what it was supposed to do, even after calling
./mach bootstrap. It seems to be the case that the bootstrap thing is
downloading the r24 SDK, however at the end the build-tools r23.0.3 are
missing. Trying to install them fails even with the SDK manager because I only
got offered r23.0.1 and the build system is insisting that it needs r23.0.3.
So, I ended up just sim-linking 23.0.1 -> 23.0.3 and that worked smoothly. :) I
wonder though whether there is something more straightforward we can suggest on
the doc...

https://trac.torproject.org/projects/tor/ticket/19675#comment:21

Child Tickets

Change History (5)

comment:1 Changed 18 months ago by sysrqb

While we maintain Orfox, we should decide:

1) Do we use openjdk-7 or openjdk-8?
2) build-tools-23.0.3 is not available with the hardcoded SDK mach bootstrap downloads, should we patch bootstrap so it downloads/expects 23.0.1 or should we bump the SDK tarball it downloads?

I wonder if Mozilla corrected the build-tools issues in Firefox 52+, I'll take a look at that and see if we can backport an easy patch (we can easily write our own patch, too).

For the JDK version, I have a slight preference for using openjdk-8 because it's supported, while openjdk-7 is EOL.

I'll open tickets for anything needing a tor-browser patch, but we may choose simply documenting workarounds until we start following Mozilla releases.

comment:2 in reply to:  1 Changed 18 months ago by sysrqb

Replying to sysrqb:

I wonder if Mozilla corrected the build-tools issues in Firefox 52+, I'll take a look at that and see if we can backport an easy patch (we can easily write our own patch, too).

Okay, no, they were using the same versions [0] until last year [1]. Now I wonder if Google recently changed which version of build-tools they provide. If Google stopped supporting build-tools-23.0.3 with android-sdk-r24.0.1 then that adds some complexity for us. When I looked into this last night, I found the the manifest downloaded with sdk-r24.0.1 does not contain build-tools-23.0.3 [2], but the manifest downloaded with sdk-r25.2.5 does contain it [3].

I think patching |mach bootstrap| so it fetches build-tools-23.0.1 (for the next few months) is the easiest solution.

[0] https://hg.mozilla.org/mozilla-central/rev/01b0a01a38b1
[1] https://hg.mozilla.org/mozilla-central/rev/0bae2cd79169
[2] https://dl-ssl.google.com/android/repository/repository-10.xml
[3] https://dl.google.com/android/repository/repository-11.xml

comment:3 Changed 18 months ago by sysrqb

Cc: igt0 added

comment:4 Changed 18 months ago by sysrqb

Resolution: fixed
Status: assignedclosed

Oh, yeah, done.

comment:5 Changed 18 months ago by gk

Keywords: TorBrowserTeam201804 added
Note: See TracTickets for help on using tickets.